fix(modal): add DDAU for modal visibility #140
Conversation
| @@ -4,6 +4,8 @@ | |||
| {{#uk-modal | |||
| visible=visible | |||
| on-submit=(action "submit") | |||
| on-show=(action (mut visible) true) | |||
There was a problem hiding this comment.
on-hide makes sense to me because of DDAU, but on-show looks super unnecessary: The "hide" event can be triggered from the modal, but the "show" event can't. I'd say the default implementation for show should remain in the component, and on-show would then be an extremely optional hook that we'd probably need only for very special use cases.
The public API would then be:
There was a problem hiding this comment.
If I'm not mistaken, the modal can still be opened via a button. For that case we should have the possibility to update our toggle variable.
There was a problem hiding this comment.
Right. But let's not force the user to specify on-show, because with the documented usage it's redundant.
|
@anehx I think we shouldn't force our users to implement Currently, the modal won't open if one doesn't implement it. |
|
@czosel Did you test that? Works fine in my test environment. |
## [0.8.1](v0.8.0...v0.8.1) (2019-06-11) ### Bug Fixes * **deps:** update dependencies and drop ember-cli-eslint ([1a6023d](1a6023d)) * **deps:** update ember source ([3d293ba](3d293ba)) * **modal:** add DDAU for modal visibility ([#140](#140)) ([6a3ddef](6a3ddef)) * **modal:** reintroduce option for close button ([8a719e9](8a719e9)) * **notification:** wrong property in snippet ([f925d47](f925d47)) * **syntax:** use the new template syntax ([142aa3a](142aa3a)) * **tests:** fix wrong attribute in uk-toggle-switch test ([73be406](73be406))
## [0.8.2](v0.8.1...v0.8.2) (2019-06-11) ### Bug Fixes * **deps:** update dependencies and drop ember-cli-eslint ([1a6023d](1a6023d)) * **deps:** update ember source ([3d293ba](3d293ba)) * **modal:** add DDAU for modal visibility ([#140](#140)) ([6a3ddef](6a3ddef)) * **notification:** wrong property in snippet ([f925d47](f925d47)) * **syntax:** use the new template syntax ([142aa3a](142aa3a)) * **tests:** fix wrong attribute in uk-toggle-switch test ([73be406](73be406))
|
🎉 This PR is included in version 0.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.