fix(modal): add DDAU for modal visibility (#140)

adfinis · May 14, 2019 · 6a3ddef · 6a3ddef
1 parent 8a1ae19
commit 6a3ddef
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/addon/components/uk-modal.js b/addon/components/uk-modal.js
@@ -4,6 +4,8 @@ import UIkit from "uikit";
 import { scheduleOnce } from "@ember/runloop";
 import { getOwner } from "@ember/application";
 
+const noop = () => {};
+
 export default Component.extend({
   layout,
 
@@ -30,11 +32,11 @@ export default Component.extend({
   },
 
   _show() {
-    this.modal && this.set("visible", true);
+    this.getWithDefault("on-show", noop)();
   },
 
   _hide() {
-    this.modal && this.set("visible", false);
+    this.getWithDefault("on-hide", noop)();
   },
 
   didInsertElement() {

diff --git a/tests/dummy/app/templates/components/modal.hbs b/tests/dummy/app/templates/components/modal.hbs
@@ -4,6 +4,8 @@
   {{#uk-modal
     visible=visible
     on-submit=(action "submit")
+    on-show=(action (mut visible) true)
+    on-hide=(action (mut visible) false)
   }}
     <h2 class="uk-modal-title">Test</h2>
     <p>Lorem Ipsum</p>