feat(modal): convert modal logic to modifier #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anehx
force-pushed
the
uk-modal-modifier
branch
3 times, most recently
from
ff0181e
to
43b1a08
Compare
anehx
force-pushed
the
uk-modal-modifier
branch
2 times, most recently
from
5d90c15
to
8def3fd
Compare
luytena
reviewed
Sep 13, 2022
luytena
reviewed
Sep 13, 2022
luytena
reviewed
Sep 13, 2022
anehx
force-pushed
the
uk-modal-modifier
branch
from
8def3fd
to
b2ecb34
Compare
anehx
force-pushed
the
uk-modal-modifier
branch
from
b2ecb34
to
8582896
Compare
anehx
force-pushed
the
uk-modal-modifier
branch
from
8582896
to
479f498
Compare
anehx
changed the title
Moving the modal logic to a modifier has the advantage of not needing the ember and mutation observers and the dependency on `@ember/render-modifiers`. Consuming apps that needed to enable the `default-async-observers` for modals to work should be able to disable it now.
anehx
force-pushed
the
uk-modal-modifier
branch
from
479f498
to
4ec33de
Compare
|
🎉 This PR is included in version 6.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the modal logic to a modifier has the advantage of not needing the ember and mutation observers and the dependency on
@ember/render-modifiers.Consuming apps that needed to enable the
default-async-observersfor modals to work should be able to disable it now.