Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

feat: use assignees instead of reviewers #772

Merged
merged 2 commits into from Aug 10, 2021

Conversation

trowik
Copy link
Member

@trowik trowik commented Aug 6, 2021

use assignees with reviewer role instead of project reviewers
remove reviewers table

@trowik trowik requested a review from winged August 6, 2021 12:40
winged
winged previously requested changes Aug 6, 2021
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write tests for your filters - they're not trivial pieces of code. Otherwise LGTM

timed/employment/models.py Outdated Show resolved Hide resolved
timed/projects/views.py Outdated Show resolved Hide resolved
timed/projects/views.py Show resolved Hide resolved
timed/projects/filters.py Outdated Show resolved Hide resolved
add test for full coverage
fix wrong status code or num_queries in tests
fix possibilty to create empty reports/activities for external employees
add filters for assignees
@trowik trowik marked this pull request as ready for review August 9, 2021 08:41
@trowik trowik requested a review from a team as a code owner August 9, 2021 08:41
@trowik trowik requested a review from JohnL17 August 9, 2021 08:51
@JohnL17
Copy link
Contributor

JohnL17 commented Aug 9, 2021

Overall looks good to me.

@trowik trowik dismissed winged’s stale review August 10, 2021 06:34

@JohnL17 reviewed the requested changes

@trowik trowik merged commit 8dbd006 into adfinis:master Aug 10, 2021
aziiee pushed a commit to aziiee/timed-backend that referenced this pull request Aug 18, 2021
This will update the fixtures according to adfinis#772
@aziiee aziiee mentioned this pull request Aug 18, 2021
@trowik trowik deleted the refactor-reviewer branch November 2, 2021 09:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants