fix: parse queryparams for magic link as booleans, not strings (#1046)

* fix: parse queryparam as boolean, not string * fix: dont use strictEqual to check currentRoute in test
adfinis · Aug 9, 2023 · 6076b87 · 6076b87
1 parent 6394b79
commit 6076b87
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/index/reports/controller.js b/app/index/reports/controller.js
@@ -24,8 +24,8 @@ export default class IndexReportController extends Controller {
   @tracked task;
   @tracked duration;
   @tracked comment;
-  @tracked review;
-  @tracked notBillable;
+  @tracked review = false;
+  @tracked notBillable = false;
 
   @service notify;
   @service router;

diff --git a/tests/acceptance/index-reports-test.js b/tests/acceptance/index-reports-test.js
@@ -182,7 +182,7 @@ module("Acceptance | index reports", function (hooks) {
     await click(`button[data-date="${tomorrow}"]`);
     await click("[data-test-report-save]");
 
-    assert.strictEqual(currentURL(), `/reports?day=${tomorrow}`);
+    assert.ok(currentURL().includes(`/reports?day=${tomorrow}`));
     assert.dom("[data-test-report-row]").exists({ count: 6 });
   });
 });