fix: fix of tests after changing the return type

adfinis · Mar 30, 2023 · 979e411 · 979e411
1 parent a4b1812
commit 979e411
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/app/validators/moment.js b/app/validators/moment.js
@@ -26,7 +26,7 @@ export default function validateMoment(options = { gt: null, lt: null }) {
     }
     let valid = !!newValue && newValue._isValid;
     if (!valid) {
-      return valid;
+      return "false";
     }
 
     if (options.gt) {

diff --git a/tests/unit/validators/moment-test.js b/tests/unit/validators/moment-test.js
@@ -4,7 +4,7 @@ import validateMoment from "timed/validators/moment";
 
 module("Unit | Validator | moment", function () {
   test("works without value", function (assert) {
-    assert.false(validateMoment()("key", null, null, {}, {}));
+    assert.strictEqual(validateMoment()("key", null, null, {}, {}), "false");
     assert.true(validateMoment()("key", moment(), null, {}, {}));
   });
 
@@ -19,14 +19,15 @@ module("Unit | Validator | moment", function () {
       )
     );
 
-    assert.false(
+    assert.strictEqual(
       validateMoment({ gt: "otherKey" })(
         "key",
         moment(),
         null,
         {},
         { otherKey: moment().add(1, "second") }
-      )
+      ),
+      "false"
     );
   });
 
@@ -41,14 +42,15 @@ module("Unit | Validator | moment", function () {
       )
     );
 
-    assert.false(
+    assert.strictEqual(
       validateMoment({ lt: "otherKey" })(
         "key",
         moment(),
         null,
         {},
         { otherKey: moment().add(-1, "second") }
-      )
+      ),
+      "false"
     );
   });