Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

feat: add magic link component to create a magic link that can be sent to another user #1022

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

StephanH90
Copy link
Contributor

@StephanH90 StephanH90 commented Jul 22, 2023

Description

I have wanted this feature for a long time. Behold! It's done.

New magic link btn:

image

magic link popup:

image

when following the link:

image

The report can then be changed as desired or saved directly. When you reload the page, it doesn't create the same report again.

@StephanH90 StephanH90 force-pushed the feat/magic-link branch 7 times, most recently from db301f1 to 8de7442 Compare July 23, 2023 18:45
@StephanH90 StephanH90 self-assigned this Jul 23, 2023
@StephanH90
Copy link
Contributor Author

I'm not gonna write tests for the error messages because I don't see the point. You are welcome to write them if you think they make sense.

Copy link
Contributor

@derrabauke derrabauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! ✨ If you add the suggested ignore-comments coverage will be just as shiny. 👍

app/index/reports/route.js Outdated Show resolved Hide resolved
app/components/magic-link-modal/component.js Outdated Show resolved Hide resolved
config/icons.js Show resolved Hide resolved
@derrabauke derrabauke merged commit 4096c58 into adfinis:main Jul 24, 2023
5 checks passed
adfinisbot pushed a commit that referenced this pull request Jul 28, 2023
# [3.2.0](v3.1.5...v3.2.0) (2023-07-28)

### Bug Fixes

* **activities:** prevent doubling time while generating reports ([#970](#970)) ([96f1a37](96f1a37))
* changing project in the activity bar when change the recent customer ([#998](#998)) ([05a3ce5](05a3ce5))
* **customer-visible-icon:** splatter attributes ([ee5a2b8](ee5a2b8))
* **statistics-list:** allotted efforts calculation ([a0643b4](a0643b4))
* **tests:** parameter compatibility of reports abilities ([3fc5648](3fc5648))
* the bar is green only if the task is archived and have no remeaning ([369f942](369f942))

### Features

* add magic link component to create a magic link that can be sent to another user ([#1022](#1022)) ([4096c58](4096c58))
* improve statistics bar chart rendering ([b1f1d98](b1f1d98))
* writing tests for chart rendering ([699906e](699906e))
@adfinisbot
Copy link
Member

🎉 This PR is included in version 3.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derrabauke
Copy link
Contributor

Closing #681

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants