Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with Firefox Developer Tools #6

Open
ameshkov opened this issue Jul 13, 2015 · 6 comments
Open

Integrate with Firefox Developer Tools #6

ameshkov opened this issue Jul 13, 2015 · 6 comments
Assignees

Comments

@ameshkov
Copy link
Member

We should integrate Adguard with Firefox Developer Tools.
Add Adguard button (or sidebar panel if it's possible) to FF dev tools Inspector.

https://dxr.mozilla.org/mozilla-central/source/browser/devtools/framework/gDevTools.jsm

Look how it's done in element hiding helper:
https://github.com/adblockplus/elemhidehelper/blob/master/lib/inspectorObserver.js

@ameshkov ameshkov added this to the 2.0.14 milestone Jul 14, 2015
@ameshkov ameshkov modified the milestones: 2.2, 2.0.14 Aug 13, 2015
@ameshkov ameshkov assigned Mizzick and unassigned adguard Sep 16, 2015
@Mizzick Mizzick modified the milestones: 2.3, 2.2 Feb 29, 2016
@ameshkov ameshkov modified the milestones: 2.5, 2.4 Jul 13, 2016
@worldsdream
Copy link

Looking really forward for this feature !! Subscribed

@ameshkov
Copy link
Member Author

It's more likely that we won't do it with current FF API.

Instead this issue will be automatically resolved when we migrate to WebExtensions SDK.
I feel that this SDK is not yet ready though.

@atropnikov atropnikov modified the milestones: 3.0, 2.6 Feb 7, 2017
Mizzick added a commit that referenced this issue Aug 31, 2017
…sues/728 to feature/redesign

Squashed commit of the following:

commit 757632f
Author: mizzick <ds.kolyshev@gmail.com>
Date:   Thu Aug 24 16:30:50 2017 +0300

    #728 small fix log
@Mizzick
Copy link
Contributor

Mizzick commented May 10, 2018

According to
https://developer.mozilla.org/en-US/Add-ons/WebExtensions/Using_the_devtools_APIs#Limitations_of_the_devtools_APIs
devtools integration is not yet enough implemented in FF.

@ameshkov ameshkov removed this from the 3.0 milestone Aug 10, 2018
@ghost
Copy link

ghost commented Feb 12, 2019

@Mizzick Has there been any progress on this matter?

@Mizzick
Copy link
Contributor

Mizzick commented Feb 12, 2019

@PentagramTr I will have a look what we can do. As I remember in the last FF version devtools api was not actually ready.

@ameshkov
Copy link
Member Author

@Mizzick
I checked it a couple of months ago.

The devtools.panels.createSidebarPane is now supported: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/devtools.panels/ElementsPanel/createSidebarPane

The problem is that it is still limited compared to what we have in Chromium -- you cannot specify a custom HTML layout, just a JSON object. So we cannot make it dynamic and let people construct a rule right from there.

I see that they have setPage implementation commented out in the Firefox code: https://hg.mozilla.org/integration/mozilla-inbound/rev/2cf14f576b8a#l6.63

Let's file a feature request to Mozilla about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants