-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Filtering Log v1 #11
Comments
+1 This is the feature I'm waiting the most because there are many ads that go through all the filter subscriptions... |
For now you can report these to us: Or you can read AG logs and find out what is not blocked: |
@Revertron here is a list of comments for the first filtering log implementation Filtering log iconUse this icon for the navigation menu item: Please let me know what sizes do you need. Action barWe need an option to clear the filtering log "Enabled" should the same size/weigth as action bar title has. Empty filtering logUse the same icons and layout as in the case of user filter/whitelist. Log itemTime and URL color should be of our regular gray color. |
For small icons (as 24dp in UI) we use these sizes: 96, 72, 48, 24, 36 pixels. |
@Revertron got it, what color do we need for the navigation menu? |
Other icons have $757575 color. |
Color indicationChange the line background color to indicate request status. Regular requests: no indication. |
Log item details fields should depend on the event type. However, there are some common requirements. Common requirements
Regular web request fields
Please note, that
DNS request fields
Tunnel request fields
|
Filtering log menu item icon: Fields icons: |
@Revertron just caught a crash:
|
Rules constructor issues:
|
I see that |
Add
|
Handle third-party flag in a smart way
|
Done. |
Issues:
|
Just fixed point 1. Regarding point 3, this is by design (at least for now). We should fix it eventually, but we'd better move it to a separate issue. |
done |
|
Fixed point 2. |
View 1 - Filtering Log is stopped
Placeholder
Start button
Warning about performance
Filtering Log Notification
When filtering is started we should show an ongoing notification about this.
View 2 - Filtering Log is started
List of log records.
Show for every log record:
URL
App name
Source domain
Third-Party icon
Log record color indicates if request was blocked or whitelisted.
Red for blocked, green for whitelisted, white bg - for processed.
View 3 - Log Record Details
Tapping on log record opens log record details view.
URL
Type
Source domain
Filter Rule and Filter Subscription name for blocked and whitelisted requests
Buttons:
Open in browser
Block for common requests
Unblock for blocked requests (Unblock creates whitelist rule)
Nothing for requests whitelisted by some filter subsription
View 4 - Filter Rule Creation
Example of such dialog in browser add-on:
http://screencast.com/t/kbttytH1SWj
New rules should be added to user filter.
The text was updated successfully, but these errors were encountered: