Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription auto approve doesn't work for 0.7.0 #92

Closed
AntV opened this issue Apr 24, 2012 · 8 comments
Closed

Subscription auto approve doesn't work for 0.7.0 #92

AntV opened this issue Apr 24, 2012 · 8 comments
Assignees
Labels

Comments

@AntV
Copy link

AntV commented Apr 24, 2012

I am usning Blather to create XMPP bot to retrieve information.
And this method in version 0.7.0 doesn't work, but it works for 0.5.3

subscription :request? do |s|
  write_to_stream s.approve!
end

In 0.7.0 doesn't intercept any auth request.
What is wrong?

@benlangfeld
Copy link
Member

Would you be able to check which version of Blather breaks this? 0.5.3 -> 0.7.0 is a large gap.

@ghost ghost assigned benlangfeld Apr 25, 2012
@AntV
Copy link
Author

AntV commented Apr 25, 2012

Hi, I already checked all versions from 0.5.3 to 0.7.0
The last working version is 0.6.2 so 0.7.0 only needs to be fixed.
The problem I see that subscription :request? doesn't intercept stanza at all.

@benlangfeld
Copy link
Member

Thanks. I'll get this fixed ASAP.

@sujoyg
Copy link

sujoyg commented Apr 26, 2012

A subscription stanza without the :request? guard does not intercept anything either.

@benlangfeld
Copy link
Member

Thanks, I think I know what the problem is. I will try my best to get
to it today, and release 0.7.1. Stay tuned.

@benlangfeld
Copy link
Member

Try Blather from the develop branch and let me know if you have any problems. If I don't hear anything by Monday, I'll assume this worked and release 0.7.1.

gem 'blather', :git => 'https://github.com/sprsquish/blather.git', :branch => :develop

@sujoyg
Copy link

sujoyg commented Apr 27, 2012

Ben, I tested out your current develop branch as referenced above with (1) sending and receiving subscription requests and (2) sending and receiving messages. Thumbs up on both. Thanks for the quick turnaround time. Please feel free to release 0.7.1 as soon as possible.

benlangfeld added a commit that referenced this issue Apr 29, 2012
@AntV
Copy link
Author

AntV commented Jun 11, 2012

Yeap thank everythin works fine on on 0.7.1 version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants