Handle Asterisk 'channel not found' errors correctly #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not found' output
…xecution of AGI commands
…hannels Ref should not be sent until after recording starts
|
@vindir This should be done with the exception of output components, which I will fix shortly. |
|
Changes Unknown when pulling 2c72638 on feature/channel-not-found into * on develop*. |
|
You are a a can of awesome sauce. I'll get it merged and tested once it's ready. |
…ry to execute on dead channels
|
@vindir Please test with your project and let me know if this solves the problem :) Once you report back I'll get this merged to develop. |
…ture separate from AGI
| def execute(ami_client) | ||
| ami_client.send_action 'AGI', 'Channel' => @channel, 'Command' => agi_command, 'CommandID' => id | ||
| rescue RubyAMI::Error => e |
There was a problem hiding this comment.
Need to get rid of the duplication between this and Call#send_ami_action before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP. This needs extending to all touches to Asterisk for both AMI and AGI, including handling differently in components vs basic commands.