Fix travis ci suite #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….9 (JRuby 1.7) compatible Note: term-ansicolor and tins (sub-dependencies of coveralls) do not follow SemVer
…JRuby 1.7) compatible Note: listen (sub-dependency of guard) does not follow SemVer
NoMethodError: undefined method `last_comment' for #<Rake::Application:0x464e808b> ~/.rvm/gems/jruby-1.7.19/gems/rspec-core-2.99.2/lib/rspec/core/rake_task.rb:143:in `initialize' ~/Code/ruby_speech/Rakefile:7:in `(root)'
…t stable version of Bundler
houndci-bot
reviewed
Dec 9, 2016
| @@ -1,4 +1,9 @@ | |||
| require 'ruby_speech' | |||
| # encoding: utf-8 | |||
There was a problem hiding this comment.
Missing frozen string literal comment.
benlangfeld
approved these changes
Dec 9, 2016
|
Awesome, thank you Ben!! =) |
|
Since we can't trust rbx version numbers, I'm happy to make its failure allowed. No-one sane actually uses it anyway. |
|
Sounds good, marking them as allowed and hoping for a green test suite to come through! =) |
|
Almost forgot... shall I also include the following key from the adhearsion .travis.yml? notifications:
slack:
secure: Y7EqF/9FY7mca63c1DM7kEr34fNtFclWXJj9vLqVQJwR3rCDZUZSD8DlqHJDwE6KRCCDsSkyV4lihCim+GEM28CRcJir0AEUJhXHvIMckjH7n38W9OGN26RuJGZTapjgCSMOBeq0YpSe6dAnZeRpZRJxsTFtP5ptLD5RRjIMzZM= |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a number of test-related issues regarding development_dependencies and testing environment setup:
Development_dependency fixes:
Note: term-ansicolor and tins (sub-dependencies of coveralls) broke SemVer by cutting off ruby 1.9 support apart from a major release
Similarly, the listen sub-dependency of guard broke SemVer in this regard as well.
Once we upgrade to rspec 3.0+, we can lift this restriction
Environment setup fixes:
Other changes:
Let me know if this is overkill.
Known and expected issues