Fix CI build for Ruby 2.1 and 2.2 #56
Conversation
Attempt to get rbx-3 to install.
> If you鈥檙e using macOS or Trusty environments, you can also use Rubinius. @see https://docs.travis-ci.com/user/languages/ruby/#rubinius
sfgeorge
force-pushed
the
fix-ci-for-older-rubies
branch
from
47eb48f
to
cad2066
Compare
|
@lpradovera @gfaza Can you review this for me sirs? |
.travis.yml
Outdated
| @@ -1,9 +1,12 @@ | |||
| dist: trusty | |||
There was a problem hiding this comment.
It appears this distribution applies to all versions of Ruby being tested? Trusty reached End Of Life on April 30th, 2019. I don't think it makes sense to continue testing on this. If the justification is to support older Ruby versions, then maybe we need to drop support for those instead. I don't see a lot of value in continuing to support old versions of Ruby going forward. Anyone on an older Ruby can use a similarly older version of Ruby Speech.
There was a problem hiding this comment.
@bklang That's a good point. I know that we tout Rubinius compatibility, but I haven't seen it be practical to use Rubinius with a recent version of a Travis image, unfortunately.
Using dist: trusty got us a little further in the right direction (the only image that successfully rvm-installs "rbx-3" and "rbx-4"), but it would still choke on trying to natively compile extensions for ffi. Since trusty still can't effectively get us to a place where it actually runs the builds for rbx, then it doesn't provide any value.
So yeah, we should probably use something more recent and leave rbx in "allow_failures" for the time being.
There was a problem hiding this comment.
We always wanted to support Rubinius, but I've never heard of anyone actually using it. Even in CI, Rubinius has always been marked to allow_failures. I definitely would not consider it a platform with full support. It's a nice-to-have.
| @@ -14,13 +17,11 @@ matrix: | |||
| allow_failures: | |||
| - rvm: rbx-3 | |||
| - rvm: ruby-head | |||
| sudo: false | |||
There was a problem hiding this comment.
This used to be necessary to make use of newer Travis infrastructure (iirc, without this, the test would run on a VM). Is that no longer the case?
There was a problem hiding this comment.
@bklang Yes, it looks like it's now deprecated. I was going off of this info from https://docs.travis-ci.com/user/reference/overview/#deprecated-virtualization-environments :
If you鈥檙e trying to use sudo: false or dist: precise keys in your travis.yml, we recommend you switch to our current Xenial Linux infrastructure.
I've already seen in bef35c1 that the build works great on Xenial (apart from Rubinius, which was already broken). Should we just go with Xenial?
There was a problem hiding this comment.
@bklang Thank you sir! Ready for re-reviewski :monocle:
Side note: Why is there no monocle emoji? 馃槥
|
^ Says the most qualified gentleman on the subject of top hats! 馃憣 Dig it! 馃帀 |
| - gem install bundler | ||
| env: | ||
| global: | ||
| - JRUBY_OPTS='--debug' |
There was a problem hiding this comment.
@bklang FYI I think adding JRUBY_OPTS='--debug' on this particular PR was needed in order to prevent Coveralls from reporting that coverage was dropping.
Fix CI build
gem install bundlertries to install Bundler 2.x on all Rubies, including those < 2.3, which is a no-go:Solution is to just simply omit
gem install bundler, and just let travis do the work of deciding which version of bundler to install.drop use of sudo: true/false, as that's deprecated.
Switch to
dist: trustyto get slightly closer to successfully running with rbx / Rubinius. Unfortunately, I couldn't getffito natively compile under Rubinius and I'm not quite sure why. 馃槥Use versions of Ruby 2.3 and 2.4 that come pre-installed on Travis' Xenial build.
Begin testing Ruby 2.5 and 2.6.