Skip to content

Commit

Permalink
[FIX] theme_kea: fix the data of shape on s_picture in KEA theme
Browse files Browse the repository at this point in the history
Commit [1] refreshed the design of the KEA theme but unfortunately
introduced the wrong path to a shape on the s_picture snippet.

This used to cause a traceback but [2] fixed it. However, it is still
worth correcting the path so that shapes automatically chain under the
s_picture snippet of that theme.

To do so, a simple check is added when the option computes the next
shape, and looks for the broken path, if it finds it, it corrects it.

Steps to reproduce:
- Use the KEA theme
- Drop the "Picture" snippet
- Drop the text snippet under it
- Enable the background shape option for the text snippet
- The first shape is selected instead of the next one in the series.

To fix properly in master of course.

[1]: odoo@88b81d4
[2]: odoo/odoo@e985f8e

opw-3082292

closes odoo#619

Related: odoo/odoo#107224
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
  • Loading branch information
detrouxdev authored and qsm-odoo committed Dec 21, 2022
1 parent 600f3b6 commit f3bd5ab
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions theme_kea/views/snippets/s_picture.xml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<!-- Section -->
<xpath expr="//section" position="attributes">
<attribute name="class" add="o_cc3" remove="o_cc2" separator=" "/>
<!-- TODO: adapt in master, this was fixed in JS -->
<attribute name="data-oe-shape-data">{"shape":"web_editor/Origins/Wavy_03","flip":["y"]}</attribute>
</xpath>
<!-- Shape -->
Expand Down

0 comments on commit f3bd5ab

Please sign in to comment.