Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract header, table, tr logic to helper #15

Merged
merged 3 commits into from Sep 1, 2018
Merged

Conversation

adhocore
Copy link
Owner

@adhocore adhocore commented Sep 1, 2018

Introduction

This is a

  • New feature
  • Fix for ...
  • General improvement
  • Backward incompatible change

It closes #

Describe the change

Internal refactor

@codecov-io
Copy link

codecov-io commented Sep 1, 2018

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #15   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      111    117    +6     
=======================================
  Files             4      4           
  Lines           233    248   +15     
=======================================
+ Hits            233    248   +15
Impacted Files Coverage Δ Complexity Δ
src/BlockElementParser.php 100% <100%> (ø) 49 <0> (-10) ⬇️
src/HtmlHelper.php 100% <100%> (ø) 17 <16> (+16) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31e002...53f582c. Read the comment docs.

@adhocore adhocore merged commit ea892fb into master Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants