Merge pull request #46 from adidas/bugfix/align-no-unused-vars

ALIGN no unused vars for JavaScript
adidas · Feb 19, 2021 · 6a88f0d · 6a88f0d
2 parents e15f242 + 44475c3
commit 6a88f0d
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ This changelog is only to log changes of the project base.
 If there are changes on the packages, please, check and update the changelog of each package accordingly.
 -->
 
+## 1.9.6
+
+- Updated configuration for `eslint-config-adidas-es5`.
+
 ## 1.9.5
 
 - Replaced TravisCI by GitHub Actions

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "js-linter-configs",
-  "version": "1.9.5",
+  "version": "1.9.6",
   "description": "adidas configurations for JavaScript linting tools",
   "license": "MIT",
   "contributors": [

diff --git a/packages/eslint-config-adidas-es5/CHANGELOG.md b/packages/eslint-config-adidas-es5/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.3.2
+
+- Updated `no-unused-vars` config to match `@typescript-eslint/no-unused-vars`.
+
 ## 1.3.1
 
 - Disabled `require-unicode-regexp`.

diff --git a/packages/eslint-config-adidas-es5/index.js b/packages/eslint-config-adidas-es5/index.js
@@ -241,7 +241,7 @@ module.exports = {
     'no-unsafe-optional-chaining': 'off',
     'no-unused-expressions': 'off',
     'no-unused-labels': 'error',
-    'no-unused-vars': [ 'error', { vars: 'all', args: 'after-used' }],
+    'no-unused-vars': [ 'error', { vars: 'all', args: 'after-used', ignoreRestSiblings: true, caughtErrors: 'none' }],
     'no-use-before-define': 'off',
     'no-useless-backreference': 'error',
     'no-useless-call': 'error',

diff --git a/packages/eslint-config-adidas-es5/package.json b/packages/eslint-config-adidas-es5/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-adidas-es5",
-  "version": "1.3.1",
+  "version": "1.3.2",
   "description": "ESLint base configuration and rules for all JavaScript codebases",
   "license": "MIT",
   "contributors": [