New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: entryOrder First #29

Merged

adierkens merged 1 commit into adierkens:master from deini:enum

Jun 12, 2019

Contributor

deini commented Jun 12, 2019

@adierkens had an issue since enums start at 0 this check right here wasn't passing

webpack-inject-plugin/src/main.ts

Line 121 in 1adf822

entryOrder: (options && options.entryOrder) || ENTRY_ORDER.NotLast,

Two options: Check for undefined or just start enum at 1.


          fix: entryOrder First

b4d2c3b

adierkens merged commit d8a7b1a into adierkens:master

Owner

adierkens commented Jun 12, 2019

Thanks for the fix!
It's released in 1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment