Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache binary per version when installing with npm #21

Merged
merged 1 commit into from
Dec 20, 2022
Merged

cache binary per version when installing with npm #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions npm/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const request = require('request'),
path = require('path'),
constants = require('./constants');

const { name, platform, arch, binaryName, bin, binaryUrl } = constants;
const { name, platform, arch, binaryName, bin, binaryUrl, version } = constants;

if (!arch) {
error(`${name} is not supported for this architecture: ${arch}`);
Expand All @@ -27,7 +27,7 @@ const MAX_RETRIES = 3;

const install = () => {
const tmpdir = os.tmpdir();
const binary = path.join(tmpdir, binaryName);
const binary = path.join(tmpdir, `${binaryName}-${version}`);

const copyBinary = () => {
const dest = path.join(bin, binaryName);
Expand Down
2 changes: 1 addition & 1 deletion npm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@adikari/safebox",
"version": "1.2.5",
"version": "1.2.6",
"description": "A Fast and Flexible secret manager built with love by adikari in Go",
"main": "index.js",
"bin": "./run.js",
Expand Down