Change the ussage of FormattedText to TextLine #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@whistyun thank you for fixing this. I gave it a try and all is working as expected. However, I noticed that after removing the useCheapGlyphMeasurement (assuming same width for all chars in a long line), now AvaloniaEdit is unable to handle very long lines, such this file. Trying to move the caret/edit the long line is impossible. Could you please bring back the useCheapGlyphMeasurement? I know this is not perfect implementation, but I'd like for now to keep what we had working. AFAIK @Gillibald will add horizontal virtualization in PR AvaloniaUI#216, which will be a much better implementation. |
|
Sorry, I had missed AvaloniaUI#204 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to fix AvaloniaUI#204 (comment)
These changes ensure that character widths are measured correctly.