Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance with larger lists really bad #20

Closed
mrusme opened this issue May 29, 2022 · 3 comments
Closed

Performance with larger lists really bad #20

mrusme opened this issue May 29, 2022 · 3 comments
Assignees

Comments

@mrusme
Copy link

mrusme commented May 29, 2022

I'm running gomp on a pretty powerful machine, yet with a larger playlist of over 1k entries the TUI feels awfully sluggish. Pressing arrow down for a few seconds and letting it go makes the selection continue to advance for several seconds before it stops.

@aditya-K2
Copy link
Owner

aditya-K2 commented May 30, 2022

I just had a look and you were right. Initially I thought this must be because the progress bar makes multiple draw requests every second, but upon disabling it, the issue still persists. I have a feeling this has something to do with tview's drawing method (not totally sure).

@aditya-K2
Copy link
Owner

aditya-K2 commented May 31, 2022

I have a feeling this has something to do with tview's drawing method (not totally sure).

I was wrong. I think the slow down might be because of the constant fetching of current playlist from the mpd server

@aditya-K2 aditya-K2 self-assigned this Jun 25, 2022
aditya-K2 added a commit that referenced this issue Sep 13, 2022
As mentioned at #20 (comment)

The Slow Down was caused due to constant calls to the MPD Server for
playlist info. Using Watcher to handle playlist event changes.

Also when In SearchView upon adding Artist/Album due to constant change
in playlists there was a slow down. Hence using CommandList for that.
@aditya-K2
Copy link
Owner

Fixed with #35

aditya-K2 added a commit that referenced this issue Oct 19, 2022
As Mentioned in #20 The Performance with larger list was very sluggish.
PR #35 tried fixing it with reducing the server request. But during
Empty Playlist checks there were constant server requests, which caused
a bottleneck and with list sizes of greater than 6000 there was a slow
down. This commit tries to fix that by checking the local Playlist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants