Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ViT #104

Merged
merged 2 commits into from
May 18, 2023
Merged

Fix ViT #104

merged 2 commits into from
May 18, 2023

Conversation

jasonjewik
Copy link
Collaborator

  • Fixed timm version to 0.9.2
  • Removed unused linear.py
  • Removed unused patchify() method of VisionTransformer
  • Cleaned up unpatchify() method
  • Added projection head at the end of VisionTransformer for arbitrary translation from n embed dims to m output channels

@jasonjewik jasonjewik linked an issue May 18, 2023 that may be closed by this pull request
Current ViT implementation works with timm 0.6.12 and not with 0.9.2 #102
Closed
prakhar6sharma
prakhar6sharma approved these changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@prakhar6sharma prakhar6sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@prakhar6sharma prakhar6sharma merged commit d60ca2d into main May 18, 2023
6 checks passed
@prakhar6sharma prakhar6sharma deleted the fix-vit branch May 18, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prakhar6sharma prakhar6sharma prakhar6sharma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current ViT implementation works with timm 0.6.12 and not with 0.9.2
2 participants
@jasonjewik @prakhar6sharma