Fastsearch params bug fix #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i.e. if params.fuseOpts.threshold is 0.0 or params.fuseOpts.ignorelocation is false, the default values of 0.4 and true will still be used.
|
Kudos, SonarCloud Quality Gate passed!
|
adityatelange
approved these changes
Sep 2, 2022
minyeamer
pushed a commit
to minyeamer/hugo-PaperMod
that referenced
this pull request
Sep 16, 2022
RoneoOrg
added a commit
to RoneoOrg/hugo-theme-offTheRecord
that referenced
this pull request
Sep 30, 2022
* upstream/master: (51 commits) [PATCH] Fix date format in schema and opengraph templates Fix error with profileMode imageUrl on Windows devices when imageUrl was set with external link resources.Get throws an error Use Nullish Coalescing Operator with Fastsearch (adityatelange#1033) Update bug report template add sketchfab icon (adityatelange#998) Fix spotify icon svg (adityatelange#997) Updating pagination strings for de (adityatelange#1024) Add icons for AniList and osu! (adityatelange#1022) Fix spacing around `rawhtml` shortcode (adityatelange#1018) Add param 'hiddenInHomeList' to hide certain post from home page Fix Code Smell: Unexpected var, use let or const instead. Add social icons for DeviantArt and Patreon (adityatelange#1013) Adding threema as social icon (adityatelange#1012) Feat: Add page nums in list pages pages: use github actions as build source - remove older build config (Classic Pages) Add more ja translations (adityatelange#1004) Updating pagination strings for bn: (adityatelange#1002) Add optional custom "title" for social links (adityatelange#999) Add a meta tag for naver site verification (adityatelange#991) add vimeo icon (adityatelange#975) ...
dunklecat
pushed a commit
to dunklecat/hugo-PaperModX
that referenced
this pull request
Oct 9, 2022
kylethedeveloper
pushed a commit
to kylethedeveloper/hugo-PaperMod
that referenced
this pull request
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. if params.fuseOpts.threshold is 0.0 or params.fuseOpts.ignorelocation is false, the default values of 0.4 and true will still be used.
What does this PR change? What problem does it solve?
Changing the code for grabbing the fuse parameters to use the nullish coalescing operator instead of doing boolean coercion, since boolean coercion prevents certain values from being propagated.
I.e. params.fuseOpts.ignorelocation ? params.fuseOpts.ignorelocation: true will always be true. I don't think I have seen this discussed, and just happened to find the bug while working with the theme :)
Was the change discussed in an issue or in the Discussions before?
PR Checklist