Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

underline entry title on hover #1402

Conversation

vindex10
Copy link

@vindex10 vindex10 commented Jan 26, 2024

What does this PR change? What problem does it solve?

cursor: pointer is intuitive when the whole entry is clickable.

with PR #1401 , it may happen that rendered summary contains a link. Then it becomes confusing which link is this: inner or outer.

Generally, it feels nice to have underlined links referring to clickable action.
I suggest to underline the title of the entry, when mouse is over the link.

I suggest this change independently on the PR 1401.

Was the change discussed in an issue or in the Discussions before?

no

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adityatelange
Copy link
Owner

Hi @vindex10 please discuss in issues before you open PRs

@adityatelange
Copy link
Owner

Closing as this is an amend for #1401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants