Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the use of accesskey #1494

Closed
wants to merge 1 commit into from
Closed

Conversation

xuhdev
Copy link

@xuhdev xuhdev commented Apr 17, 2024

What does this PR change? What problem does it solve?

accesskey is quite problematic. MDN advises not using accesskeys for general purpose websites for various reasons: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey#accessibility_concerns

WebAIM also recommends against using accesskeys generally: https://webaim.org/techniques/keyboard/accesskey

Was the change discussed in an issue or in the Discussions before?

No.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

`accesskey` is quite problematic. MDN advises not using accesskeys for general purpose websites for various reasons: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesskey#accessibility_concerns

WebAIM also recommends against using accesskeys generally: https://webaim.org/techniques/keyboard/accesskey
Copy link

sonarcloud bot commented Apr 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@adityatelange
Copy link
Owner

It will stay until browsers remove the support

@xuhdev
Copy link
Author

xuhdev commented Apr 20, 2024

I don't think browsers will ever drop support because access keys are useful in some cases. The PR description says they are not recommended to be used in a general website, citing various sources.

@adityatelange
Copy link
Owner

image
Some users find this useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants