Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate call to hugo.Generator #786

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

JannikArndt
Copy link
Contributor

@JannikArndt JannikArndt commented Feb 15, 2022

Currently, the theme adds the

<meta name="generator" content="Hugo 0.92.1" />

tag to every page (source: https://github.com/adityatelange/hugo-PaperMod/blob/master/layouts/partials/head.html#L107-L108).

Problems with this:

  1. it doesn't respect the disableHugoGeneratorInject setting
  2. it differs from the intention of the tag, which is to only appear on the main page (see documentation here and comment by bep here)

The solution is really simple: For some versions now, the theme doesn't have to add the tag anymore. If it's not present, hugo will just add it (if disableHugoGeneratorInject isn't true). So removing this code and using the latest version of hugo gives you the intended behaviour.

PR Checklist

  • This change adds/updates translations and I have used the template present here.
  • I have enabled maintainer edits for this PR.
  • I have verified that the code works as described/as intended.
  • This change adds a Social Icon which has a permissive license to use it.
  • This change does not include any CDN resources/links.
  • This change does not include any unrelated scripts such as bash and python scripts.
  • This change updates the overridden internal templates from HUGO's repository.

@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@adityatelange adityatelange merged commit 43c810c into adityatelange:master Feb 15, 2022
kylethedeveloper pushed a commit to kylethedeveloper/hugo-PaperMod that referenced this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants