Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

38 deprecate creation of npm mdprofiles package #55

Merged
merged 12 commits into from
Oct 10, 2023

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Oct 2, 2023

Closes #38
Closes #39
Closes #48
Closes #56

Breaking Changes

This will break mdEditor v1.0.1 profiles. Will need to coordinate merging into master with a new deployment of mdEditor.

Changes

  • Remove npm package code/files
  • Remove NGGDPP profiles and associated files
  • New manifest file - renamed from core-profiles
    • renamed key from 'identifier' to 'name'
  • profile-schema modified to support vocabularies
  • updated change log
  • updated README.md

@jwaspin jwaspin linked an issue Oct 2, 2023 that may be closed by this pull request
@jwaspin jwaspin mentioned this pull request Oct 2, 2023
2 tasks
@jwaspin jwaspin marked this pull request as draft October 2, 2023 17:31
@hmaier-fws hmaier-fws added deprecated Feature that is planned for removal and should no longer by used removed Feature that has been removed and removed deprecated Feature that is planned for removal and should no longer by used labels Oct 2, 2023
@jwaspin jwaspin marked this pull request as ready for review October 3, 2023 13:04
@jwaspin jwaspin marked this pull request as draft October 4, 2023 19:26
identifier changed to name
@jwaspin jwaspin marked this pull request as ready for review October 4, 2023 19:39
@jwaspin
Copy link
Contributor Author

jwaspin commented Oct 10, 2023

Rename vocabularies to thesauri in schema

Copy link
Contributor

@hmaier-fws hmaier-fws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@jwaspin jwaspin marked this pull request as ready for review October 10, 2023 20:31
@hmaier-fws hmaier-fws merged commit ef408d2 into develop Oct 10, 2023
@jwaspin jwaspin deleted the 38-deprecate-creation-of-npm-mdprofiles-package branch October 11, 2023 12:53
hmaier-fws pushed a commit that referenced this pull request Dec 7, 2023
* Add Separated Profiles List Files (#51)

core-profiles.json contains the default/core profiles for mdEditor.
nggdpp-profiles.json contains the NGGDPP specific profiles
that need to be moved to a separate repository.

* 38 deprecate creation of npm mdprofiles package (#55)

* Remove NPM Module Code

* Remove Custom Profiles

Remove NGGDPP profiles.
Remove old profiles lists.

* Remove NGGDPP Profiles

* Rename core-profiles -> manifest

* Update Profile Schema

Update vocabularies schema.

* Update CHANGELOG.md

* Update profile-schema.json

* Change Key Name

identifier changed to name

* Update README.md

* Update Schema

Changed Vocabularies to Thesauri.

* Update .gitignore

* Restore Production Files

* Update CHANGELOG.md (#62)

* Update README.md (#63)
hmaier-fws added a commit that referenced this pull request Jul 1, 2024
* Add Separated Profiles List Files (#51)

core-profiles.json contains the default/core profiles for mdEditor.
nggdpp-profiles.json contains the NGGDPP specific profiles
that need to be moved to a separate repository.

* 38 deprecate creation of npm mdprofiles package (#55)

* Remove NPM Module Code

* Remove Custom Profiles

Remove NGGDPP profiles.
Remove old profiles lists.

* Remove NGGDPP Profiles

* Rename core-profiles -> manifest

* Update Profile Schema

Update vocabularies schema.

* Update CHANGELOG.md

* Update profile-schema.json

* Change Key Name

identifier changed to name

* Update README.md

* Update Schema

Changed Vocabularies to Thesauri.

* Update .gitignore

* Restore Production Files

* Update CHANGELOG.md (#62)

* Update README.md (#63)

* Feature/extent vertical temporal (#65)

* feat: Add vertical and temporal properties to full-map.json

This commit adds the "vertical" and "temporal" properties to the "full-map.json" file in the resources directory. The "vertical" property includes the "description", "minValue", "maxValue", "referenceSystemType", and "referenceSystemIdentifier" fields. The "temporal" property remains empty.

* feat: Add vertical and temporal properties to basic.json

* Update Basic Profile URL

* Testing changes

* Update manifest

* Test

* feat: Add "Extent" property to basic.json

* feat: Add "Extent" property to basic.json

* feat: Add "vertical" and "temporal" properties to basic.json

* Test

* feat: Add "vertical" and "temporal" properties to product.json

* feat: Add "vertical" and "temporal" properties to basic.json

* feat: Update "crsId" property in full-map.json

* feat: Update "crsId" property in basic.json

* feat: Update "referenceSystemIdentifier" property in basic.json

* feat: Update "vertical" property in basic.json

* feat: Update manifest-develop.json with new profile URLs

* refactor: Remove unused manifest-raw-feature.json file

---------

Co-authored-by: Hilmar Maier <hilmar_maier@fws.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removed Feature that has been removed
Projects
None yet
2 participants