Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android build warning when flutter stable(2.10.4) #77

Conversation

tsuruobiz
Copy link
Contributor

@tsuruobiz tsuruobiz commented Apr 5, 2022

Hi, I build android myapp with installed the latest sdk, then the following warning occurs.

Warning: The plugin adjust_sdk requires Android SDK version 32.
One or more plugins require a higher Android SDK version.
Fix this issue by adding the following to myapp/android/app/build.gradle:
android {
  compileSdkVersion 32
  ...
}

Flutter version is here.

Flutter version 2.10.4
[✓] Flutter (Channel stable, 2.10.4, on macOS 12.3.1 21E258 darwin-arm, locale ja-JP)
    • Flutter version 2.10.4
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision c860cba910 (11 days ago), 2022-03-25 00:23:12 -0500
    • Engine revision 57d3bac3dd
    • Dart version 2.16.2
    • DevTools version 2.9.2

It seems that the PR changed compileSdkVersion 30 to 32. What is purpose to use compileSdkVersion 32?

If you don't have any reasons, I think that you should use same to flutter framework(current is 31).
https://github.com/flutter/flutter/blob/977c35307fec91301973f8b6edd43cf3b617f684/packages/flutter_tools/gradle/flutter.gradle#L33

Thanks.

@uerceg uerceg mentioned this pull request Jun 9, 2022
@uerceg
Copy link
Contributor

uerceg commented Jun 9, 2022

Hi @tsuruobiz

And thank you very much for the pull request. Most common reason for us to update compileSkdVersion is to be up to date with latest state of Android platform. But in this case, we failed to notice this warning and thank you very much for pointing out that the official framework is also using 31. Replacing this PR with #84.

Cheers!

@uerceg uerceg closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants