WKWebviewScriptBridge not supporting all WKNavigationDelegate methods

[joshuafrancisrak]

https://github.com/adjust/ios_sdk/blob/master/AdjustBridge/WebViewJavascriptBridge/WKWebViewJavascriptBridge.m

We are using didCommit and webviewProcessDidTerminate
But since the bridge does not forward events, we can no longer receive those events if we install the AdjustBridge

Can we request to have the other WKNavigationDelegate funcs to be called and forwarded?

[joshuafrancisrak]

For those having problems with unimplemented navigationDelegate funcs, you can use code below
But basically we are adding method to DispatchTable , and sending the message upwards

`
extension WKWebViewJavascriptBridge {
struct SwizzleStatic {
static var once = true
}

class func swizzle() {
    guard SwizzleStatic.once else {
        return
    }
    SwizzleStatic.once = false
    
    let swizzleAddMethod = { (selector: Selector, originalSelector: Selector) in
        guard let method = class_getInstanceMethod(self, selector),
              let imp = class_getMethodImplementation(self, selector) else {
                  assertionFailure("Could not create method / imp")
                  return
              }
        class_addMethod(self, originalSelector, imp, method_getTypeEncoding(method))
        return
    }
    
    let didCommitToAddSelector = #selector(WKWebViewJavascriptBridge.swizzleAdded_webView(_:didCommit:))
    let didCommitSelector = #selector(WKNavigationDelegate.webView(_:didCommit:))
    swizzleAddMethod(didCommitToAddSelector, didCommitSelector)
    
    let terminateToAddSelector = #selector(WKWebViewJavascriptBridge.swizzleAdded_webViewWebContentProcessDidTerminate(_:))
    let terminateSelector = #selector(WKNavigationDelegate.webViewWebContentProcessDidTerminate(_:))
    swizzleAddMethod(terminateToAddSelector, terminateSelector)
}

@objc func swizzleAdded_webView(_ webView: WKWebView, didCommit navigation: WKNavigation!) {
    let selector = #selector(WKNavigationDelegate.webView(_:didCommit:))
    let object = self.object(thatCanTrigger: selector)
    object?.perform(selector, with: webView, with: navigation)
}

@objc func swizzleAdded_webViewWebContentProcessDidTerminate(_ webView: WKWebView) {
    let selector = #selector(WKNavigationDelegate.webViewWebContentProcessDidTerminate(_:))
    let object = self.object(thatCanTrigger: selector)
    object?.perform(selector, with: webView)
}

private func object(thatCanTrigger selector: Selector) -> NSObjectProtocol? {
    guard let navigationDelegate = self.navigationDelegate,
          navigationDelegate.responds(to: selector) else {
              Logger.default.warning("Navigation delegate cannot be found or does not respond to selector")
              return nil
          }
    
    return navigationDelegate
}

private var navigationDelegate: WKNavigationDelegate? {
    self.value(forKey: "_webViewDelegate") as? WKNavigationDelegate
}

}
`

[uerceg]

Hi @joshuafrancisrak,

Sorry for the delay in replying and thanks for asking && actually solving this! Glad it worked for you. We're gonna take this ticket and your solution to our backlog to try to add support for this on the level of our web bridge w/o the need for you to do the swizzling.

I'll close this one for now, but will make sure to ping you in here once the functionality has been added to the web bridge. In case you have any questions, always feel free to comment / reopen.

Thank you one more time.

Cheers