-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kafka_get_watermarks() function #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me.
However we kafka_fdw--0.0.1.sql
should bot be touched as we introduce a new version here.
Review and adjustments would be easier if you develop on a branch of the same repo, this way I can't add simple commits and need to hand back changes to you
I didn't touch
I pushed |
Oh, now I see that |
..fixed this and also merged with master |
mmmh now it's not mergable anymore, can you rebase onto master? |
@zilder can finalize this? |
yes, actually i didn’t see any conflicts |
well github says so:
|
…so some refactoring (make KafkaGetConnection() independent from execution state; extract partition list fetching code to a separate function)
…er refactoring of KafkaFdwGetConnection()
This is a PR for the issue #33. Along with adding new function I also did a bit of refactoring mainly related to KafkaFdwGetConnection() in order to make it more versatile.