Create Redis cluster in CI #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines Of Code
|
Go API Changes# github.com/adjust/rmq/v5 ## compatible changes OpenClusterConnection: added OpenConnectionWithRedisOptions: added # summary Inferred base version: v5.1.3 Suggested version: v5.2.0 |
Benchmark ResultBenchmark diff with base branchBenchmark result |
Unit Test Coveragetotal: (statements) 71.5% Coverage of changed lines
Coverage diff with base branch
|
vearutop
added a commit
that referenced
this pull request
Jul 20, 2023
* fix using another wrapper to fit redis cluster and redis single node;
fix using {} to replace [] - untested
* update test files with new openConn;
add queue_cluster_test.go
welle: Remove hardcoded connection options.
* Bring back the original OpenConnection() for compatibility
Add new function OpenConnectionWithOptions() for the new approach.
* Allow cluster tests to run against local cluster
* Remove RedisClusterWrapper again
Rename RedisSingleWrapper back to RedisWrapper
* Bring back original OpenConnectionWithRedisClient()
* Add OpenClusterConnection()
To allow opening RMQ connections which use the Redis hash tags {}
instead of []. This is required to make rmq work with Redis clusters.
This commit also reverts the behavior of all other OpenConnection[...]
functions to behave as before by still using [] instead of {}.
This switch is done by using different Redis key templates. For example
instead of
rmq::connection::{connection}::queue::[{queue}]::consumers
we would use
rmq::connection::{connection}::queue::{{queue}}::consumers
when using OpenClusterConnection()
* Document OpenClusterConnection() in README
* Use safe accessors in tests
* Update deps
* Create Redis cluster in CI (#150)
---------
Co-authored-by: zhanglei <luckforzhang@vip.qq.com>
Co-authored-by: Viacheslav Poturaev <vearutop@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.