Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to remove task #153

Merged
merged 2 commits into from
Aug 22, 2023
Merged

add ability to remove task #153

merged 2 commits into from
Aug 22, 2023

Conversation

AlphaNecron
Copy link
Contributor

No description provided.

@wellle
Copy link
Member

wellle commented Aug 18, 2023

Hey! Can you please describe a use case for this feature?

@AlphaNecron
Copy link
Contributor Author

Currently, RMQ can't cancel or remove a specific task from the queue. I'm working on a project which requires cancelling a specific task but I can only cancel the task when it's consumed. This PR adds the ability to remove an item from the queue without waiting for it to be consumed.

@wellle
Copy link
Member

wellle commented Aug 21, 2023

Can you extend the comment of Remove() to mention that this can be slow? Specifically O(M+N) where M is the number of ready deliveries in the queue and N is the number of elements to be removed. Thank you!

@AlphaNecron
Copy link
Contributor Author

Sure!

@wellle wellle merged commit 86d5058 into adjust:master Aug 22, 2023
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants