Various changes #17
Open
Various changes #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a URL with parameters (like http://example.org/test.pdf?x=42) is requested generating the PDF will fail because the .pdf extension is not stripped from the URL. The regular expression for replacing the .pdf extension now correctly handles this case.
Only the path of the URL is used to create a unique output file name, but different URL parameters might result in different contents so a different file name should be used. The whole URL (including the parameters) will now be used to generate a unique file name.
The complete path to the PDF being rendered is being set in the session, making this path visible to the public. Now only the PDF filename is being set in the session.
|
👍 |
|
Is there a status update on this and merging other potential PRs? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on various changes for the gem:
Martin