Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize flags #2

Merged
merged 1 commit into from Jan 25, 2018
Merged

Actualize flags #2

merged 1 commit into from Jan 25, 2018

Conversation

hypnoglow
Copy link
Contributor

Fix flags according to documentation.

  1. I haven't found anything about MetNoLicense.
  2. DarkSkyUnavailable is actually not a bool, but a string.
    "flags": {
      "darksky-unavailable": "Dark Sky covers the given location, but all stations are currently unavailable.",
      "sources": [
        "isd",
        "cmc",
        "gfs",
        "hrrr",
        "madis",
        "nam",
        "sref",
        "darksky"
      ],
      "units": "us"
     },
    

And the whole request fails because of conversion failure: json: cannot unmarshal string into Go struct field Flags.darksky-unavailable of type bool.

@coveralls
Copy link

coveralls commented Dec 25, 2017

Coverage Status

Coverage remained the same at 94.34% when pulling f0380f9 on hypnoglow:fix-flags into 3ad8c10 on adlio:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.34% when pulling f0380f9 on hypnoglow:fix-flags into 3ad8c10 on adlio:master.

Copy link
Owner

@adlio adlio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@adlio adlio merged commit bac641b into adlio:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants