Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-add client on search endpoint #13

Merged
merged 1 commit into from
Mar 21, 2018

Conversation

luccacabra
Copy link

Currently, if a list of Board objects is retrieved via the search endpoint, we're not re-adding the client variable back into the board, which results in nil pointer errors:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x135f332]

goroutine 1 [running]:
github.com/luccacabra/trello.(*Client).Throttle(...)
	github.com/luccacabra/trello/client.go:56
github.com/luccacabra/trello.(*Client).Get(0x0, 0xc42001c360, 0x25, 0xc42010dd30, 0x1393980, 0xc4201e2240, 0x0, 0x0)
	github.com/luccacabra/trello/client.go:64 +0x52
github.com/luccacabra/trello.(*Board).GetLists(0xc4200926c0, 0xc42010dd30, 0xc42010dd30, 0xc42010dd60, 0xc42010dd30, 0x0, 0x13ab2e0)
	github.com/luccacabra/trello/list.go:40 +0x107
main.TrelloBoard(0xc420014900, 0x20, 0xc420018280, 0x40, 0xc420016958, 0x4, 0x0, 0x0, 0x0, 0x0, ...)
...

@coveralls
Copy link

coveralls commented Mar 14, 2018

Coverage Status

Coverage increased (+0.07%) to 70.144% when pulling 2b95606 on luccacabra:search-boards-client into 4701389 on adlio:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 70.144% when pulling 2b95606 on luccacabra:search-boards-client into 4701389 on adlio:master.

@adlio
Copy link
Owner

adlio commented Mar 21, 2018

Thank you @luccacabra. Oversight on my part, I haven't used the search APIs much. Merging.

@adlio adlio merged commit 9d645a6 into adlio:master Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants