Allow getting a new client with a context.Context #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context is great to allow for cancellation of requests. With this change it will be possible to get a new client which will set a different context for all it's requests. This solution is backwards-compatible. However, since this package always embeds itself to provide methods like *Board.GetLists(). The current solution could lead to memory leaks or using old contexts if the user is holding the responses in memory.
1 similar comment
|
@adlio what is your plan to deprecate support for old Go versions? It is possible to work around the current failure with some build tags. But I'm wondering whether it's worth it. The last three major versions have been out for over a year and a half. |
|
@ernesto-jimenez I'm fine with deprecating now, assuming we maintain backwards compatibility with the trello package API, which your change does. Want to update the PR with travis config changes? I'm still considering the implications of client/context re-use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context is great to allow for cancellation of requests.
With this change it will be possible to get a new client which will set
a different context for all its requests.
This solution is backwards-compatible. However, since this package
always embeds itself to provide methods like *Board.GetLists(). The
current solution could lead to memory leaks or using old contexts if the
user is holding the responses in memory.