Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "start" field to trello.Card #88

Merged
merged 3 commits into from
Mar 28, 2022
Merged

Add "start" field to trello.Card #88

merged 3 commits into from
Mar 28, 2022

Conversation

Rukenshia
Copy link
Contributor

@Rukenshia Rukenshia commented Apr 14, 2021

This PR adds the "start" field from the trello api which was introduced some time last year to the Card struct.

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #88 (dab0f63) into master (f1fa5fb) will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   73.38%   73.51%   +0.12%     
==========================================
  Files          22       22              
  Lines         853      857       +4     
==========================================
+ Hits          626      630       +4     
  Misses        195      195              
  Partials       32       32              
Impacted Files Coverage Δ
card.go 57.01% <100.00%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1fa5fb...dab0f63. Read the comment docs.

@Rukenshia
Copy link
Contributor Author

I added a function to be able to test/validate the request parameters as I couldn't find anything else doing that yet - hope that works for you.

@adlio
Copy link
Owner

adlio commented Mar 11, 2022

Thanks for the contribution! Hoping to review and merge this weekend.

@adlio adlio mentioned this pull request Mar 28, 2022
@adlio adlio merged commit 6b2a544 into adlio:main Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants