Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format tweaks #1036

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Format tweaks #1036

merged 1 commit into from
Jun 22, 2017

Conversation

aakoch
Copy link
Contributor

@aakoch aakoch commented Mar 23, 2017

Add blank lines and spaces to correct rendering of headers

Add blank lines and spaces to correct rendering of headers
@garemoko
Copy link
Contributor

The blank lines shouldn't be needed #1034 fixes those issues in a different way.

The extra space on line 141 (How to Contribute) isn't covered by #1034. Good catch.

@garemoko garemoko mentioned this pull request Mar 23, 2017
@garemoko
Copy link
Contributor

In fact, #1034 missed fixing this file. I do thing the approach of #1034 fixing the anchor tags rather than adding a line space is better though.

Do you agree? If so, do you want to change your PR to follow that approach or shall I incorporate this file into #1034? It's a quick task for me to do, I just don't want to steal your thunder :-)

@garemoko
Copy link
Contributor

I went ahead and rolled the anchor fixes for contributing.md into #1034.

I did not include the extra space on line 141 (How to Contribute) though, so if you remove the extra line breaks from this PR and just leave that extra space then we can merge it.

@andyjohnson
Copy link
Contributor

Similar to #1035 , went with the larger merge first. Please re-submit working from the current merge if you can. Thanks!

@garemoko
Copy link
Contributor

@andyjohnson I think this one can now be closed since #1039 includes this fix and more.

@garemoko garemoko mentioned this pull request Jun 21, 2017
@andyjohnson andyjohnson merged commit ff0562a into adlnet:master Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants