Skip to content
This repository has been archived by the owner on Sep 15, 2023. It is now read-only.

Correct Display the Booster Vaccination not as Incomplete #247

Closed
ojehle opened this issue Nov 24, 2021 · 3 comments
Closed

Correct Display the Booster Vaccination not as Incomplete #247

ojehle opened this issue Nov 24, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@ojehle
Copy link

ojehle commented Nov 24, 2021

Swiss Covid App shows Booster Vaccinations as Incomplete Vaccinations
in my certificate i have 3 doses of a total of 2 needed.

I expect the same on the android version

diff --git a/Wallet/Screens/Certificates/CertificateDetailView.swift b/Wallet/Screens/Certificates/CertificateDetailView.swift
index ebfb2d9..4c89e1d 100644
--- a/Wallet/Screens/Certificates/CertificateDetailView.swift
+++ b/Wallet/Screens/Certificates/CertificateDetailView.swift
@@ -81,7 +81,7 @@ class CertificateDetailView: UIView {

     addDividerLine()
  •    if vaccinations.allSatisfy({ $0.doseNumber == $0.totalDoses }) {
    
  •    if vaccinations.allSatisfy({ $0.doseNumber >= $0.totalDoses }) {
           addTitle(title: UBLocalized.translationWithEnglish(key: .covid_certificate_vaccination_title_key))
       } else {
           addTitle(title: UBLocalized.translationWithEnglish(key: .wallet_certificate_type_incomplete_vaccine_key))
    

diff --git a/Wallet/Screens/Certificates/CertificateDetailViewController.swift b/Wallet/Screens/Certificates/CertificateDetailViewController.swift
index 2035dcf..4df70b5 100644
--- a/Wallet/Screens/Certificates/CertificateDetailViewController.swift
+++ b/Wallet/Screens/Certificates/CertificateDetailViewController.swift
@@ -247,7 +247,7 @@ class CertificateDetailViewController: ViewController {
case let .success(holder):
guard let certificate = holder.certificate as? DCCCert else { break }
let vaccinations = certificate.vaccinations ?? []

  •        if !vaccinations.allSatisfy({ $0.doseNumber == $0.totalDoses }) {
    
  •        if !vaccinations.allSatisfy({ $0.doseNumber >= $0.totalDoses }) {
               title = UBLocalized.wallet_certificate_evidence_title.uppercased()
           }
       case .failure:
    
@ojehle
Copy link
Author

ojehle commented Nov 24, 2021

not shure if doseNumber and totalDoses must be switched equal or less ..... but anyway.. it looks like the booster makes the number of doses applied higher, but the fixed number 2 (for moderna/pfizer) will stay on the certificate. in my case 3/2.

@goebelUB
Copy link
Contributor

Thanks for reporting! This seems to be a UI issue in the wallet. Even though we show the wrong strings (e.g. the title "Vaccination incomplete"), the certificate itself should still be shown as valid (blue box with "Only valid with an identity document").

Could you please check that your cert is also shown green in the verifier (Covid Check)?

On a side note: as far as I know booster certs should be issued as 3/3. Is this a Swiss certificate?

@goebelUB goebelUB added the bug Something isn't working label Nov 29, 2021
@ojehle
Copy link
Author

ojehle commented Nov 29, 2021

It's a certificate from liechtenstein...

It's valid in both apps.

the certificate is valid - green with the check app.
and valid with document in the blue app.

but i think it's still correct the information in the certificate. because for moderna you need 2 doses that it's valid. the booster is recommended, but not a must.

I was not sure if the totalDoses or doseNumber is the "must" have dose.. anyway.. if the amount of injections i got is higher then the one i must have, it should be not shown as "incomplete"...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants