Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching Strategy for Reference: what about referredSemanticId? #347

Open
BirgitBoss opened this issue Feb 6, 2024 · 2 comments
Open

Matching Strategy for Reference: what about referredSemanticId? #347

BirgitBoss opened this issue Feb 6, 2024 · 2 comments
Assignees
Labels
documentation Improvements or additions to documentation requires workstream approval strategic decision in spec team needed
Milestone

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented Feb 6, 2024

A Reference has a type, a referredSemanticId and a list of keys. In the chapter "Matching Strategies - Matching Algorithm for References" the referredSemanticId is not mentioned. Which impact does the referredSemanticId has on the matching algorithm?

The Note Note: if the key types are not identical although all key values follow the correct order of the key chain, then at least one of the references is buggy and a warning should be issued. is true for match model-ref against model-ref and external-ref against external-ref but not for external-ref against model-ref. This should be added

@BirgitBoss BirgitBoss added the requires workstream approval strategic decision in spec team needed label Feb 6, 2024
@BirgitBoss BirgitBoss added this to the V3.1 milestone Feb 6, 2024
@BirgitBoss BirgitBoss added the documentation Improvements or additions to documentation label Feb 6, 2024
@g1zzm0
Copy link
Collaborator

g1zzm0 commented Feb 7, 2024

Can you please provide an algorithmic solution how XML or JSON Objects should be mapped and matched in pseudocode

BirgitBoss added a commit that referenced this issue Feb 18, 2024
rename exact matching to value matching
new matching type: equivalent matching
BirgitBoss added a commit that referenced this issue Feb 21, 2024
* bugfix tables in Chapter Common Attributes
+ some editorial fixes

* terms and definitions adopted to IEC 63278-1
change log updated accordingly listing changed
terms and definitions
abbrevations: minor adoptions to IEC 63278-1

* bugfix <<abstract>>, needs ""

* editorial changes only

* closes #350
added notes to avoid misunderstanding and misuse

* closes #347
rename exact matching to value matching
new matching type: equivalent matching

* Update documentation/IDTA-01001/modules/ROOT/pages/IDTA-01001_General.adoc

Co-authored-by: s-heppner <s.heppner@plt.rwth-aachen.de>

* Update documentation

Add in the context

Co-authored-by: s-heppner <s.heppner@plt.rwth-aachen.de>

---------

Co-authored-by: Nico Braunisch <nico.braunisch@tu-dresden.de>
Co-authored-by: s-heppner <s.heppner@plt.rwth-aachen.de>
@BirgitBoss
Copy link
Collaborator Author

TF Part 1 2024-03-07 Discussion
We should consider to forbid that a semanticId has a Reference/referredSemanticId by constraint.

https://rwth-iat.github.io/aas-specs-antora/IDTA-01002-3/snapshot/IDTA-01002_Spec_Interfaces.html#_operation_getallsubmodelsbysemanticid
Which kind of semanticId match is used for this operation? This needs to be decided. In future additional parameter for matchingStrategy probably necessary

Instead of heading "Equivalence matching of two references" use same wording as for semantic ID matching. instead of "identical" use string-identical.
Ignore referredSemanticId for References because they have no identifying function.

It seems that "Equivalence" and Value Matching for References are identical: both describe that keys are identical. All values identical and number of elements in the key chain is identical.
Since semanticId is also a REference: check, whether rules of Matching References are compatible with those for semanticId

P.S. Fix ")" (GlobalReference 0173-1#01-ADS698#010, (FragmentReference)0173-1#01-ADS700#010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation requires workstream approval strategic decision in spec team needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants