Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional values for all SubmodelElements #412

Open
alexgordtop opened this issue Apr 16, 2024 · 3 comments
Open

Optional values for all SubmodelElements #412

alexgordtop opened this issue Apr 16, 2024 · 3 comments
Assignees
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone

Comments

@alexgordtop
Copy link

The constraints / cardinalities affecting the value of the SubmodelElements are inconsistent.

It is not obvious, why especially ReferenceElement.value, but also Property.value, File.value, Blob.value are optional, but e.g. RelationshipElement.first/second is required.

Request:
Please revise required attributes with the aspect of defining a template structure / incomplete model in mind.


Issue caused by restriction:
This mandatory constraint leads currently to issues with AASX serialization, since some IDTA SubmodelTemplates would like to specify the usage of e.g. RelationshipElements, but when deserializing a corresponding AASX, the parsers will fail according to a xml schema violation.


Beside SubmodelTemplates, there are other UseCases, where a kind of requested structure should be provided, that somebody else would have to fill like:

Use case:
A component has an empty configuration, that the operator should fill to configure the asset.
Using RelationshipElements is nearly impossible in the situation.

The same applies to File/Blob.contentType - if a component allows an attachment, it is forced to specify something like "/", if it is open for different kinds of values. From a modeler perspective, I would have preferred to not set the contentType in advance and describe in the description, that a kind of image or pdf is accepted as documentation, but no videos.

@BirgitBoss
Copy link
Collaborator

TF Metamodel 2024-04-17
Discussion not yet finalized but recommendation:

  • at least for (Annotated)RelationshipElement make "first" and "second" optional (conformant to min and max of Range)

@BirgitBoss BirgitBoss added this to the V3.1 milestone Apr 17, 2024
@BirgitBoss BirgitBoss added the specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally label Apr 17, 2024
@BirgitBoss BirgitBoss self-assigned this Apr 18, 2024
BirgitBoss added a commit that referenced this issue May 5, 2024
most changes were already done
- fix Value-Only schema
- fix ChangeLog again
- update figure for SME with inheritance
-
BirgitBoss added a commit that referenced this issue May 5, 2024
…425)

most changes were already done
- fix Value-Only schema
- fix ChangeLog again
- update figure for SME with inheritance
-
@BirgitBoss BirgitBoss added the ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream label May 15, 2024
@BirgitBoss
Copy link
Collaborator

Decision Proposal TF Part 1 2024-05-15
Besides #412 (comment) make the following attributes optional as well:
File/contentType
Blob/contentType

Reason:

  • contentType may not be fixed at time of creation of a SMT
  • even for a Submodel with kind=Instances representing a configuration file that is sent to another stakeholder for filling in the gaps the information might not be available

BirgitBoss added a commit that referenced this issue May 15, 2024
+ update ChangeLog
+ update Figures
+ update Value-Only Serialization (also make Range min,max optional as defined in Metamodel)

Additionaly fix DataElement: Stereotype <<abstract>> was missing
@BirgitBoss
Copy link
Collaborator

Workstream AAS Sepc 2024-06-13
accepted
make the following attributes optional

  • (Annotated)RelationshipElement/first
  • (Annotated)RelationshipElement/second
  • File/contentType
  • Blob/contentType

@BirgitBoss BirgitBoss added accepted accepted in principle to be fixed and removed ready for approval TF proposes how to resolve the issue. Needs final approval my Workstream labels Jun 13, 2024
BirgitBoss added a commit that referenced this issue Jun 20, 2024
* closes #412 make File/contentType and Blob/contentType optional
+ update ChangeLog
+ update Figures
+ update Value-Only Serialization (also make Range min,max optional as defined in Metamodel)

Additionaly fix DataElement: Stereotype <<abstract>> was missing

* fix figure DataElement Overview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Development

No branches or pull requests

2 participants