-
Notifications
You must be signed in to change notification settings - Fork 14
Clarify Release Process #61
base: development
Are you sure you want to change the base?
Conversation
- Fixes branch names - Adds section to mention CI workflows and their effects
Feature/docfxworkflow
…otation for id and element type)
- bump to 1.2.1
Feature/deploy to sonatype
…at as current AML serialization specification does not cover attribute introduces in model v3.0) - added unit tests for simple example (serialization does currently loose information as as current AML serialization specification does not cover attribute introduces in model v3.0)
Is now triggered on release published
Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
Bugfix/aml serializer
…zation Bugfix/reference deserialization
Bugfix/serialization
This is a dummy commit to trigger the workflows.
Oh and the fact that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wholeheartedly agree that we need to clarify the development and release process.
However, the current commit still looks inconsistent to me. I see two options
- work on
development
, once a set of features/bugfixes that is release-worthy has accumulated, make PR fromdevelopment
tomain
which triggers CI to release to maven. Push todevelopment
should release to Github. Problem: We are not generating a tag corresponding to the release, i.e. we are "loosing" the code basis of the release.
Possible solution: add creating tag to CI release action - abandon
development
and work directly on main but change CI to only publish to maven on tag. Push tomain
should release to Github.
Current PR mixes both approaches as it uses development
but triggers release only on tag.
Please change PR to implement one of both approaches.
@@ -5,8 +5,8 @@ | |||
name: Generate and Deploy to Sonatype | |||
|
|||
on: | |||
push: | |||
branches: [ main ] | |||
release: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not match what is in the description, i.e. that a push on main triggers a release to maven central. However, I agreed that we should only trigger releases upon tags to ensure we have properly archived the code base for each release.
@alw-iwu @mjacoby if this issue is still relevant, please open a new ticket at https://github.com/eclipse-digitaltwin/aas4j. I will close this one next week. |
There is still no clarity toward the versioning of commits. The updated docs represent the policy I remember agreeing upon a while back which was never properly documented and adhered to during developement. We should however be very clear to avoid confusion such as here.