Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

Clarify Release Process #61

Open
wants to merge 21 commits into
base: development
Choose a base branch
from

Conversation

arnoweiss
Copy link
Contributor

There is still no clarity toward the versioning of commits. The updated docs represent the policy I remember agreeing upon a while back which was never properly documented and adhered to during developement. We should however be very clear to avoid confusion such as here.

Daespen and others added 21 commits November 19, 2021 10:20
- Fixes branch names
- Adds section to mention CI workflows and their effects
…at as current AML serialization specification does not cover attribute introduces in model v3.0)

- added unit tests for simple example (serialization does currently loose information as as current AML serialization specification does not cover attribute introduces in model v3.0)
Is now triggered on release published
Signed-off-by: Frank Schnicke <frank.schnicke@iese.fraunhofer.de>
This is a dummy commit to trigger the workflows.
@arnoweiss
Copy link
Contributor Author

Oh and the fact that developement was way behind main is another sign we should clarify the development process.

Copy link
Contributor

@mjacoby mjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wholeheartedly agree that we need to clarify the development and release process.
However, the current commit still looks inconsistent to me. I see two options

  1. work on development, once a set of features/bugfixes that is release-worthy has accumulated, make PR from development to main which triggers CI to release to maven. Push to development should release to Github. Problem: We are not generating a tag corresponding to the release, i.e. we are "loosing" the code basis of the release.
    Possible solution: add creating tag to CI release action
  2. abandon development and work directly on main but change CI to only publish to maven on tag. Push to main should release to Github.

Current PR mixes both approaches as it uses development but triggers release only on tag.
Please change PR to implement one of both approaches.

@@ -5,8 +5,8 @@
name: Generate and Deploy to Sonatype

on:
push:
branches: [ main ]
release:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not match what is in the description, i.e. that a push on main triggers a release to maven central. However, I agreed that we should only trigger releases upon tags to ensure we have properly archived the code base for each release.

@sebbader-sap
Copy link

@alw-iwu @mjacoby if this issue is still relevant, please open a new ticket at https://github.com/eclipse-digitaltwin/aas4j. I will close this one next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants