Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gen 4] Bug Catching contest / Safari Pokemon on HGSS. #1

Closed
RichardPaulAstley opened this issue Jun 21, 2017 · 9 comments
Closed

[Gen 4] Bug Catching contest / Safari Pokemon on HGSS. #1

RichardPaulAstley opened this issue Jun 21, 2017 · 9 comments
Assignees
@SteveCookTU @Real96
Labels
enhancement
Projects
Gen 4 Support

Comments

@RichardPaulAstley
Copy link

So first, the links as I told you :
https://www.reddit.com/r/pokemonrng/comments/2cfxsq/bug_catching_contest_gen_4_rng/
https://www.reddit.com/r/pokemonrng/comments/3ef7c0/bug_catching_contest_rng_without_cute_charm/

And an example of somebody trying without any results :
http://www.smogon.com/forums/threads/past-gen-rng-research.61090/page-13#post-2987503

Was not able to find something else sadly. Nothing on main guides etc, really something missing.

In RNGReporter, it's known that frames are not displayed correctly. The 4th Gen Time Finder says nothing about this, but when you generate results on the main frame :

image

A warning is here about this, but of course, NO FRAME are bold when you check (0 bold in 100k of results). So really there's something wrong about these methods.

Because the goal of this would be to AVOID Cute Charm which can be difficult to do (in my game for example, i don't have access to this)

And moreover, having the possibility to display GOOD frames would be cool.

For ending, I can tell you my own experience : I've searched for a SHiny adamant Scyther. It was frame 86. I hit the seed correctly of course, I up it to the right frame... And got a pokemon at a frame around 175 higher than excepted.

Thanks o/
@Admiral-Fish
Copy link
Owner

Related to bug catching https://pastebin.com/Y0VRnJxu

@Admiral-Fish
Copy link
Owner

Related to safari zone https://github.com/pret/pokeemerald/blob/1e4f12e6fa9e3b22d4f1a60ca69313b5dec0ca38/src/wild_encounter.c#L310-L336

@Admiral-Fish Admiral-Fish added this to To do in Gen 4 Support Apr 1, 2018
@Admiral-Fish Admiral-Fish mentioned this issue May 1, 2019
Closed
@Orionsilver
Copy link

THANK YOU
U R AWESOME

@RichardPaulAstley
Copy link
Author

image

Maybe not supported, but checking a random wild will give wrong encounter slots

@Admiral-Fish
Copy link
Owner

https://github.com/shinyfinder/Safari-ES-Calculator/blob/master/index.html

@RichardPaulAstley
Copy link
Author

1IV seems to be enough to make it working

@Real96
Copy link
Collaborator

Real96 commented Feb 5, 2022 •
edited

BCC generation: https://github.com/yatsuna827/Pokemon4genRNGLibrary/blob/09bcdd108e7a98fc6acee50e9db78b8bcceb4b45/Pokemon4genRNGLibrary/IndividualGenerator/IIndivGenerator.cs#L67

BCC encounter slots:
https://github.com/pret/pokeheartgold/blob/master/src/overlay_bug_contest.c#L287-L309
https://github.com/pret/pokeheartgold/blob/master/src/overlay_bug_contest.c#L168
https://github.com/pret/pokeheartgold/blob/031177154991146d2a3440a58945c96f3d88f645/include/bug_contest_internal.h
https://github.com/pret/pokeheartgold/blob/031177154991146d2a3440a58945c96f3d88f645/files/data/mushi/mushi_trainer.csv

@Real96 Real96 mentioned this issue Mar 2, 2022
Merged
Admiral-Fish added a commit that referenced this issue Mar 15, 2022
@Real96 @Admiral-Fish @SteveCookTU
[Gen 4] Bug Catching Contest (partial #1) (#233)
ae59637 
* Added basic gen4 BCC generation

* Added gen4 BCC encounter slots

* Added correct BCC generation in gen4 generator

* Force user to set at least one flawless IV in BCC Searcher

* Add bug encounter data

* Requested change to bcc warning message

* Fixed locations in HGSS BCC encounters file

* Initial loading of bug contest data

* Add level to bug contest

* Add level to bug contest searcher

* Attempt cute charm fix for bug contest

* Remove unnecessary if clause

* Renamed BCC location

* Refactor to remove duplicate lines

* Whitespace and version check

* Remove unused, additions for encounter lookup

* Added National Dex checkBox to Gen4 profile editor

* Add profile defaults

* Requested changes

* Small tweaks

* Create template for difference in bug contest generation

* Show bcc days in the correct order

* Forgot to show bcc days in the correct order in searcher too

* Requested changes

Return bool from createPokemon
Completely skip loop on successful cute charm
Move common state calculations back to main function
Remove unnecessary variables and checks

* Missing breaks

* Tweak early exit from loop

* Fix missing PID calculations

Simplify switch statement within loop

* Add missing nature filter check

* Revert "Add missing nature filter check"

This reverts commit 0fd8dcf.

* Re-Add filter check after loop

* Move filter checks to proper positions

* Re-Add if to skip loop when not necessary

* Remove some duplication

* Nit changes

* Added national dex in wild4 window inside the profile section

Co-authored-by: Admiral-Fish <admiralfish420@gmail.com>
Co-authored-by: Steve Cook <steviecook210@gmail.com>
@SteveCookTU SteveCookTU moved this from To do to In progress in Gen 4 Support Mar 15, 2022
@Real96 Real96 self-assigned this Apr 12, 2022
@Real96
Copy link
Collaborator

Real96 commented Apr 22, 2022

BCC added in ae59637

@Real96 Real96 mentioned this issue Apr 30, 2022
Closed
@Admiral-Fish
Copy link
Owner

Closed this as fixed in the redesign branch

Safari added via 18a5ee4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SteveCookTU SteveCookTU

@Real96 Real96

Labels
enhancement
Projects
No open projects
Gen 4 Support
  
In progress
Milestone
No milestone
Development

No branches or pull requests
5 participants
@SteveCookTU @Orionsilver @Real96 @Admiral-Fish @RichardPaulAstley