-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this plugin still maintained? #547
Comments
I have the same question. looking weekly for updates but nothing happens. |
Wating.. |
I observed that using plugin version> 1.11.1 (or we can say using the latest version 1.20.0 or 1.28.0) receives fewer ads. This means the variety of ads decreases and repetitive ads are shown. Does anyone face the same issue? @EYALIN @kisimediaDE ? Using old versions like 1.11.1 or 1.10.0 works fine for Android os version <=10 but for Android os 11, 12 the app is crashing as soon as we try to open the app. Let me know if anyone observes the same. |
@mujaffars after investigating, we didn't have such an issue |
According to my knowledge this plug-in is using Google states that all version between 7 and 19 will completely stop functioning from April 1st 2023. Are my findings correct and what can we do - as a community - to update this plug-in and keep receiving ads? |
I tried to fork the repo and run it locally because there are very good migration guides. So if someone else would give it a try and needs help with following the migration guides I'm more then open to help 🙂 Here are so many people maybe we can find a group? |
@kisimediaDE what I did is to fork it (you can take it from my repo/Pr) and added some missing files->npm install I upgraded the ADMOB SDK for IOS and Android and all works |
@EYALIN I did see (and did inspect the source-code) of your repo (some hours ago). I did not implement it, yet (because I try to discover first what is going on). When the original plug-in started (years ago) I did commit several changes as well (mainly non-coding issues), but after a year or so it became quit. But regarding your repo I do have two question, which I hope you can answer.
MIGRATION WARNINGS BELOW 20 = DEPRECATED The plug-in in the And migrating from anything lower than I am a front-end / somehow back-end coder myself and somehow "good" in creating Cordova-apps, but only for Android and I don't have enough knowledge of the plug-in system. So let's see what we - the community - can do to maintain this plug-in.I am more than willing to support where and with whatever I can (but both Java and Swift are out of my scope). We can create a new landingspage with additional info / a straight link to an new repo / make things more clear to other users, etc... |
This is really bad news? We need to request/convince @ratson to do the plugin upgrade. He can help us with that, but I don't know how we can do that. He was not actively maintaining this plugin for long. @EYALIN if you can do the upgrade and have the knowledge, please help us with that. Also please create npm package so that it can be used with volt.build for app creation. |
@mjapps-games @1n3JgKl9pQ6cUMrW for Apple mobile ads SDK the latest is 10.3.0 (I don't know what version for Apple will be deprecated, can you please check as well?) for Android, yes, it's going to be deprecated. but, we are talking about "PLAY_SERVICES_VERSION" for Android which is "20.6.0" in the current plugin ( I upgraded to 21.1.5) |
@EYALIN we are using https://volt.build/ for the creation of apk file, for that the package needs to be published on npm. Can you publish your package to https://www.npmjs.com/ Regarding your comment about "PLAY_SERVICES_VERSION" I am confused -- Are you saying current version will not stop showing ads in 1 week? |
@mjapps-games maybe it will deprecate (personally i think yes). |
@EYALIN Can you answer my first question? we are using https://volt.build/ for the creation of apk file, and for that the package needs to be published on npm. Can you publish your package to https://www.npmjs.com/ |
Okay, there is a lot of confusing (because it is confusing), so let me try to bring some light (hopefully). @EYALIN the latest version for And the latest version for The plug-in uses Please confirm those numbers and platforms 🙃 My findingsWhen I log in to my Admob account @ Google, I got a warning message about the deprecation of the The latest version for the From what I understand, this is not about the Also this will impact Android (please correct me, when I am wrong). Upgrade pathIf we want to receive ads in Q2 of 2023, we must upgrade the Doing so will break the existing plug-in, because there are so many version "in between". So from my understandings, we have about a couple of weeks and than the party is over. What we must do now;
Of course I can throw a couple of thousand bucks on the table and hire a Cordova / Android / Java developer myself, but that won't help the community. I think Ratson does have it's own argument not to participate in this / his plug-in any longer, which we should all respect. He did an amazing job building this from scratch, was fighting for the freedom (of speech) in his home country and did help us through the Covid-19 years... big should out to him. (and know we have to deal with this as our own problem) |
Again, it's confusing (all the version numbers, SDK, dependencies, etc...). The Where the From what I understand now, the version numbers of the So even when I am wrong, we must prepare for the future of this plug-in. I am willing to to pay for it, hire a developer, etc... but it would be nice if the community can handle this by itself. There are so many Cordova Admob plug-ins out there, but all of them are years old and not trustworthy (besides this one). |
@1n3JgKl9pQ6cUMrW for the Android it is the Google Play Services SDK. |
SituationOkay, things are getting clearer now and I will try to sort things out (for myself and everybody else).
Plug-in versions
Like I mentioned above, the plug-in remains the same but the dependencies are updates (preventing ads to disappear and / or other misbehavior). SKD overviewThis plug-in uses the The The And both SDK do need an update soon. For And for Used SDK'sThe original plug-in uses the For the All those mentioned changes can be tracked in the filediff here. Deprecation scheduleGoogle also announced a deprecation / sunset schedule for the mentioned version numbers. Once again, check this out for For So when you do not upgrade from plug-in version The newest version in For This update will not break anything within your app but on both Sidenote AndroidAll The same is for |
Thank you @1n3JgKl9pQ6cUMrW for the brief details. We need to plan how we are going to upgrade it. I don't have much experience on Java end, but reviewed some code and tried to understand it. It is a little bit complicated to understand for someone who doesn't know each detail about it. If someone can provide a tutorial about it then it will be helpful. We can also think about docker container creation, which can be used for the testing purposes -- Just a thought. |
I started with Java way back in the '90s but lot's have changed since than and writing Java is not my strongest point (when I started, there were only applets inside the Kameleon and Navigator browser). For For now we are good with the newest update from @EYALIN but within one or two years, this plug-in really needs to get / receive new updates. Luckily the sourcecode is here to stay and quite easy to read / maintain (for those with enough knowledge). So I thinks "we" as a community must take this job and try to do it ourself and also keep contact about the main direction this plug-in is heading to. @ratson really did an outstanding job. |
Hey everyone, sorry for the simple seeming question. How do I install the plugin from @EYALIN GitHub? @1n3JgKl9pQ6cUMrW |
Or download the .zip at More info about local installs. Basically the install process is the same as the original plug-in, but only with a different endpoint. Since @ratson is not the creator of the newest version, I suggest to deploy it first locally and test it to see if it will fit your needs. |
@1n3JgKl9pQ6cUMrW thank you very much for the detailed explanation! highly appreciated |
Thanks. I've gotten this far.
What are the end points? I've installed plugins from GitHub and local
before but this repo has multiple plugins in it.
…On Wed, Mar 29, 2023 at 5:27 PM 1n3JgKl9pQ6cUMrW ***@***.***> wrote:
Hey everyone, sorry for the simple seeming question. How do I install the
plugin from @EYALIN <https://github.com/EYALIN> GitHub? @1n3JgKl9pQ6cUMrW
<https://github.com/1n3JgKl9pQ6cUMrW>
CLI with repo https://github.com/EYALIN/admob-plus.git
Or download the .zip at
https://github.com/EYALIN/admob-plus/archive/refs/heads/master.zip and
install it manually (on your local machine) by referring to the path you
unzipped it.
Basically the install process
<https://admob-plus.github.io/docs/cordova/installation> is the same as
the original plug-in, but only with a different endpoint.
—
Reply to this email directly, view it on GitHub
<#547 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJGOFR3O2BUMDCPXTIVIATW6SSNVANCNFSM6AAAAAASCBYLBE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Depends on the framework you are using for the app. Ionic? Plain Cordova? Etc... Maybe it's better to open a new topic for this, so others can also find answers for the same problem. |
It's a plain cordova. I'm not asking how to install a plugin, I can do that. What's specific about this repo is there are many plugins. I've tried this I've tried the same but from my local, neither works. Can you help? |
Maybe it's better to open a new topic for this, so others can also find answers for the same problem. This repo has just one plug-in, but it's wrapped in difference namespaces for different frameworks. Ionic, Cordova (native), React, etc... Your example is not a valid .git endpoint, it's the main repo. Just download the package and unzip it to a local folder. Than install it by pointing to the Cordova folder you need;
The last folder must (as always) contain the This is how it works since the very beginning, just check out this thread from ten years ago. More info at the official page. |
Before installing the repository, you have to build the js files first (Change the repo and package to the one you use), the
Now you can install the repo as follows.
This only needs to be done again if you modify any of the js in the repo, if you change the java, xml... you just have to uninstall and install the plugin again. |
@EYALIN you want me to push the changes from my fork to yours? My fork includes support for WebView API for Ads and a fix for the following bug on iOS #530 (cf773d9) |
cool! Good to know the plugin still active. |
that will be great, thanks! :-) אד |
I sent my pull request EYALIN#1 When you can, also activate the issues tab in you fork |
I tried installing through Git, I get this error: I |
Have you removed the old plugin before adding the new one? cordova plugin remove admob-plus-cordova |
Thanks @ollm. I created another app. Installation was successful. I built an Android app and installed on the phone. When I open the App, it breaks after the logo. Wondering what I did wrong. Use Plain Cordova. Like you suggested, admob-plugin-cordova is no longer part of the new build. Is it a requirement to admob-plus-cordova-native? |
What error appears in the logcat? |
I use Notepad++ for file edit and run on chrome browser. On the browser. admob isn't fired so no issues. I build with Cordova build Android and install the apk file on my phone. This is where I notice the problem. I cant log. |
Test the app in the Android Studio Emulator so you can see the errors in logcat. |
Thanks. Will do this and provide feedback |
I tried to work with it, but had some errors using the webview. thanks a lot for your code donation! :-) |
https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/releases/tag/v0.0.5 |
|
@Amaeta are the errors related to which plugin? what version? |
@Amaeta the crash in your app is caused by the plugin You can try removing the plugin. cordova plugin remove cordova-plugin-background-mode Or apply one of the solutions discussed here katzer/cordova-plugin-background-mode#577 |
Thanks a bunch. Removed the background-mode plugin and it is working now. The only issue is that I can't get the native ad to show. Interstatia and banner works well. Could be my code? function showNativeAd(){
}; |
Ads must be loaded before displaying
https://github.com/admob-plus/admob-plus/blob/master/examples/cordova/www/js/index.js |
Yes, I have ad.load(); first. Do I need to install the native admob plugin differently or does community-admob-plus plugin enough? |
To use native ads it is necessary to install the You can get more information in the native ad documentation: https://admob-plus.github.io/docs/cordova/ads/native |
emi-indo-cordova-plugin-admob ( New Platform IOS )https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/discussions/3 |
New Features AppOpenAd ( support Any mediation ) |
I have installed it from npm, but i do not understand how to use it in my ionic app. |
@degroundshaker can you be more specific? and you can open a new issue in the community-admob-plus-cordova plugin repo |
Update New Featureshttps://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/releases/tag/v.1.0.9 |
@ratson please update us if you are back. |
@EYALIN See my plan in #539 (comment) For those need to the latest SDKs, please try the latest @EMI-INDO Good work! For those looking for an alternative, feel free to try it out. |
Is this plugin still maintained?
The text was updated successfully, but these errors were encountered: