Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this plugin still maintained? #547

Closed
EYALIN opened this issue Nov 16, 2022 · 80 comments
Closed

Is this plugin still maintained? #547

EYALIN opened this issue Nov 16, 2022 · 80 comments

Comments

@EYALIN
Copy link

EYALIN commented Nov 16, 2022

Is this plugin still maintained?

@kisimediaDE
Copy link

I have the same question. looking weekly for updates but nothing happens.

@EYALIN
Copy link
Author

EYALIN commented Dec 3, 2022

@ratson did some commits 10 days ago to a different repository, so we are lucky he is still using Github :-)

@ratson when you are back I will donate a monthly sponsorship.

@mujaffars
Copy link

Wating..

@mujaffars
Copy link

I observed that using plugin version> 1.11.1 (or we can say using the latest version 1.20.0 or 1.28.0) receives fewer ads. This means the variety of ads decreases and repetitive ads are shown. Does anyone face the same issue? @EYALIN @kisimediaDE ?

Using old versions like 1.11.1 or 1.10.0 works fine for Android os version <=10 but for Android os 11, 12 the app is crashing as soon as we try to open the app.

Let me know if anyone observes the same.

@EYALIN
Copy link
Author

EYALIN commented Feb 14, 2023

@mujaffars after investigating, we didn't have such an issue

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

According to my knowledge this plug-in is using Google-Mobile-Ads-SDK version 8.13.0

Google states that all version between 7 and 19 will completely stop functioning from April 1st 2023.

Are my findings correct and what can we do - as a community - to update this plug-in and keep receiving ads?

Clipboard 1

@kisimediaDE
Copy link

I tried to fork the repo and run it locally because there are very good migration guides.
But I was not able to run it 🫠
(Have not much experience with Plugins like this)

So if someone else would give it a try and needs help with following the migration guides I'm more then open to help 🙂

Here are so many people maybe we can find a group?

@EYALIN
Copy link
Author

EYALIN commented Mar 27, 2023

@kisimediaDE what I did is to fork it (you can take it from my repo/Pr) and added some missing files->npm install
and then remove the admob plus package and reinstall it with the forked path for Cordova folder
please update us here so we will be able to help.

I upgraded the ADMOB SDK for IOS and Android and all works

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 27, 2023

@kisimediaDE what I did is to fork it (you can take it from my repo/Pr) and added some missing files->npm install and then remove the admob plus package and reinstall it with the forked path for Cordova folder please update us here so we will be able to help.

I upgraded the ADMOB SDK for IOS and Android and all works

@EYALIN I did see (and did inspect the source-code) of your repo (some hours ago).

I did not implement it, yet (because I try to discover first what is going on).

When the original plug-in started (years ago) I did commit several changes as well (mainly non-coding issues), but after a year or so it became quit.

But regarding your repo I do have two question, which I hope you can answer.

  1. In your commits I see only code-changes for the iOS version, not Android (besides some version bumps)? Is this correct?
  2. Google says migrating from 7 - 19 to 20 (or higher) will have many breaking changes (causing the plug-in to stop). Is this correct?
  3. And in your version the SDK is updated to Mobile Ads SDK - version 9.x - but version 9 is also deprecated in Q2 of 2023. Is this correct?

Clipboard 1

MIGRATION WARNINGS


Clipboard 1

BELOW 20 = DEPRECATED


The plug-in in the master (here) still uses Mobile Ads SDK - version 8.x, while the newest version is already at 22 (so we are many version behind).

And migrating from anything lower than 19 to a higher SDK, will have breaking changes... so the plug-in code (both Android and iOS) must have some thorough rewrites?

I am a front-end / somehow back-end coder myself and somehow "good" in creating Cordova-apps, but only for Android and I don't have enough knowledge of the plug-in system.

So let's see what we - the community - can do to maintain this plug-in.

I am more than willing to support where and with whatever I can (but both Java and Swift are out of my scope).

We can create a new landingspage with additional info / a straight link to an new repo / make things more clear to other users, etc...

@mjapps-games
Copy link

This is really bad news? We need to request/convince @ratson to do the plugin upgrade. He can help us with that, but I don't know how we can do that. He was not actively maintaining this plugin for long.

@EYALIN if you can do the upgrade and have the knowledge, please help us with that. Also please create npm package so that it can be used with volt.build for app creation.

@EYALIN
Copy link
Author

EYALIN commented Mar 28, 2023

@mjapps-games @1n3JgKl9pQ6cUMrW for Apple mobile ads SDK the latest is 10.3.0 (I don't know what version for Apple will be deprecated, can you please check as well?)

for Android, yes, it's going to be deprecated. but, we are talking about "PLAY_SERVICES_VERSION" for Android which is "20.6.0" in the current plugin ( I upgraded to 21.1.5)
I recommend to all, taking my pr locally, run npm install and install the package from the Cordova folder there.

@mjapps-games
Copy link

@EYALIN we are using https://volt.build/ for the creation of apk file, for that the package needs to be published on npm. Can you publish your package to https://www.npmjs.com/

Regarding your comment about "PLAY_SERVICES_VERSION" I am confused -- Are you saying current version will not stop showing ads in 1 week?

@EYALIN
Copy link
Author

EYALIN commented Mar 28, 2023

@mjapps-games maybe it will deprecate (personally i think yes).
I'm just saying that when you are referring to Mobile Ads SDK, it will refer to apple, and when talking about Android so it is the play services version (which will be deprecated next week) that contains inside the "play-services-ads"

@mjapps-games
Copy link

@EYALIN Can you answer my first question?

we are using https://volt.build/ for the creation of apk file, and for that the package needs to be published on npm. Can you publish your package to https://www.npmjs.com/

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 28, 2023

Okay, there is a lot of confusing (because it is confusing), so let me try to bring some light (hopefully).

@EYALIN the latest version for iOS is 10.x (which will break iOS 10 and 11, but that's nothing you can do about it).

And the latest version for Android is 21x (where 22.x will be out in the wild soon).

The plug-in uses 8.x for iOS (that's what you say?) and 20.x for Android (when I understand you right?).

Please confirm those numbers and platforms 🙃


My findings

When I log in to my Admob account @ Google, I got a warning message about the deprecation of the Google Mobile Ads SDK (for Android).

The latest version for the Android Admob SDK is 22.x where our Admob Cordova plug-in stil uses 8x ... correction; that's for iOS (I fetched it from the sourcecode) ... but which version is the plug-in using for Android than / then?

new


From what I understand, this is not about the Google Play Version SDK but strictly the Mobile Ads SDK and that last one is already deprecated and will totally stop functioning within weeks.

temp

Also this will impact Android (please correct me, when I am wrong).


Upgrade path

If we want to receive ads in Q2 of 2023, we must upgrade the Google Mobile Ads SDK from version 8 (iOS) and version x (Android) to at least 10 (iOS) and for Android to 21 or even 22 (this is really confusing).

Doing so will break the existing plug-in, because there are so many version "in between".

okay


So from my understandings, we have about a couple of weeks and than the party is over.


What we must do now;

  1. Confirm that we are talking about the Google Mobile Ads SDK and not the Google Play services SDK.
  2. Find a solution for it.

Of course I can throw a couple of thousand bucks on the table and hire a Cordova / Android / Java developer myself, but that won't help the community.


I think Ratson does have it's own argument not to participate in this / his plug-in any longer, which we should all respect.

He did an amazing job building this from scratch, was fighting for the freedom (of speech) in his home country and did help us through the Covid-19 years... big should out to him.

(and know we have to deal with this as our own problem)

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 28, 2023

Again, it's confusing (all the version numbers, SDK, dependencies, etc...).


The Google Admob SDK version for iOS is 8.x and is updated by @EYALIN to 10.x

n


a

Where the Google Playservices SDK for Android is 20.x which is updated as well in the same repo to 21.x


From what I understand now, the version numbers of the AdMob Mobile Ads SDK - Android which are deprecated soon are not referring to the Mobile Ads SDK but the Google Play Services SDK?


So even when I am wrong, we must prepare for the future of this plug-in.

I am willing to to pay for it, hire a developer, etc... but it would be nice if the community can handle this by itself.

There are so many Cordova Admob plug-ins out there, but all of them are years old and not trustworthy (besides this one).

@EYALIN
Copy link
Author

EYALIN commented Mar 28, 2023

@1n3JgKl9pQ6cUMrW for the Android it is the Google Play Services SDK.
I'm working on improving the patch and will try to upload it as an npm package, so it will be easy to consume it.

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 29, 2023

Situation

Okay, things are getting clearer now and I will try to sort things out (for myself and everybody else).

  1. This plug-in is awesome (for many of us), but needs upgrades and maintenance.
  2. Since the original creator is somehow AFK, we (the community) must / can / will do this ourself.

Plug-in versions

  • The most current version (made by @ratson ( of this plug-in is 1.28.0 and can be found here.
  • But because dependencies are running out of time (more on that below) user @EYALIN updated the most important SDK's for both iOS and Android, bumping the version to 1.29.0. which can be found here.

Like I mentioned above, the plug-in remains the same but the dependencies are updates (preventing ads to disappear and / or other misbehavior).


SKD overview

This plug-in uses the Google Mobile Ads SDK and does this both for Android and iOS.

The iOS version can be seen as a "native" SDK, so it's stand-alone and must be integrated "as is" in your app (since Google can't provide their complete framework insides Apples software environment).

The Android version also uses this Google Mobile Ads SDK but here it's part of the complete "Android" framework, called Google Play services.

And both SDK do need an update soon.

For Android the deprecation schedule of the Mobile Ads SDK can be found here where all the version numbers refer to the Google Play services.

And for iOS the complete overview of "needs to be updated" versions of the same SDK can be found here.


Used SDK's

The original plug-in uses the Mobile Ads SDK for Android (which is part of the Google Play services) version number 20.6.0 (plug-in version 1.28.0) and is updated in 1.29.0 to version 21.5.0.

For the iOS version, the SDK is updated from 8.13.0 to 10.1.0.

All those mentioned changes can be tracked in the filediff here.


Deprecation schedule

Google also announced a deprecation / sunset schedule for the mentioned version numbers.

Once again, check this out for Android here and iOS overhere.


For Android the active version 20.6.0 is already deprecated since Q1 2023 and will completely stop functioning in Q2 2024.

So when you do not upgrade from plug-in version 1.28.0 to 1.29.0 it will stop working within a year.

The newest version in 1.29.0. is now set to be 21.5.0 which will be deprecated in Q1 2024 and stop functioning in Q2 2025.


For iOS the current version is set to 8.13.0 where the newest version is 10.1.0.

This update will not break anything within your app but on both iOS 10 and iOS 11 the ads will stop showing (using SDK 10.1.0), according to Apple / Google.

Sidenote Android

All Android users of the new version 1.29.0 are "safe" until Q2 2025 but it's clear that we must maintain the version numbers year by year.

The same is for iOS but since that ecosystem is not part of Google, it uses different rules, schedules and sunsets.

@mjapps-games
Copy link

Thank you @1n3JgKl9pQ6cUMrW for the brief details. We need to plan how we are going to upgrade it. I don't have much experience on Java end, but reviewed some code and tried to understand it. It is a little bit complicated to understand for someone who doesn't know each detail about it. If someone can provide a tutorial about it then it will be helpful.

We can also think about docker container creation, which can be used for the testing purposes -- Just a thought.

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 29, 2023

Thank you @1n3JgKl9pQ6cUMrW for the brief details. We need to plan how we are going to upgrade it. I don't have much experience on Java end, but reviewed some code and tried to understand it.

I started with Java way back in the '90s but lot's have changed since than and writing Java is not my strongest point (when I started, there were only applets inside the Kameleon and Navigator browser).

For Android we need to maintain the code in Java but the iOS version needs Swift (as far as I know).

For now we are good with the newest update from @EYALIN but within one or two years, this plug-in really needs to get / receive new updates.

Luckily the sourcecode is here to stay and quite easy to read / maintain (for those with enough knowledge).


So I thinks "we" as a community must take this job and try to do it ourself and also keep contact about the main direction this plug-in is heading to.


@ratson really did an outstanding job.

@jasonandress
Copy link

Hey everyone, sorry for the simple seeming question. How do I install the plugin from @EYALIN GitHub? @1n3JgKl9pQ6cUMrW

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 29, 2023

Hey everyone, sorry for the simple seeming question. How do I install the plugin from @EYALIN GitHub? @1n3JgKl9pQ6cUMrW

CLI with repo https://github.com/EYALIN/admob-plus.git

Or download the .zip at https://github.com/EYALIN/admob-plus/archive/refs/heads/master.zip and install it manually (on your local machine) by referring to the path you unzipped it to.

More info about local installs.

Basically the install process is the same as the original plug-in, but only with a different endpoint.


Since @ratson is not the creator of the newest version, I suggest to deploy it first locally and test it to see if it will fit your needs.

@EYALIN
Copy link
Author

EYALIN commented Mar 30, 2023

Situation

Okay, things are getting clearer now and I will try to sort things out (for myself and everybody else).

  1. This plug-in is awesome (for many of us), but needs upgrades and maintenance.
  2. Since the original creator is somehow AFK, we (the community) must / can / will do this ourself.

Plug-in versions

  • The most current version (made by @ratson ( of this plug-in is 1.28.0 and can be found here.
  • But because dependencies are running out of time (more on that below) user @EYALIN updated both the most important SDK's for both iOS and Android, bumping the version to 1.29.0. which can be found here.

Like I mentioned above, the plug-in remains the same but the dependencies are updates (preventing ads to disappear and / or other misbehavior).

SKD overview

This plug-in uses the Google Mobile Ads SDK and does this both for Android and iOS.

The iOS version can be seen as a "native" SDK, so it's stand-alone and must be integrated "as is" in your app (since Google can't provide their complete framework insides Apples software environment).

The Android version also uses this Google Mobile Ads SDK but here it's part of the complete "Android" framework, called Google Play services.

And both SDK do need an update soon.

For Android the deprecation schedule of the Mobile Ads SDK can be found here where all the version numbers refer to the Google Play services.

And for iOS the complete overview of "needs to be updated" versions of the same SDK can be found here

Used SDK's

The original plug-in uses the Mobile Ads SDK for Android (which is part of the Google Play services) version number 20.6.0 (plug-in version 1.28.0) and is updated in 1.29.0 to version 21.5.0.

For the iOS version, the SDK is updated from 8.13.0 to 10.1.0.

All those mentioned changes can be tracked in the filediff here

Deprecation schedule

Google also announced a deprecation / sunset schedule for the mentioned version numbers.

Once again, check this out for Android here and iOS overhere

For Android the active version 20.6.0 is already deprecated since Q1 2023 and will completely stop functioning in Q2 2024.

So when you do not upgrade from plug-in version 1.28.0 to 1.29.0 it will stop working within a year.

The newest version in 1.29.0. is now set to be 21.5.0 which will be deprecated in Q1 2024 and stop functioning in Q2 2025.

For iOS the current version is set to 8.13.0 where the newest version is 10.1.0.

This update will not break anything within your app but on both iOS 10 and iOS 11 the ads will stop showing (using SDK 10.1.0), according to Apple / Google.

Sidenote Android

All Android users of the new version 1.29.0 are "safe" until Q2 2025 but it's clear that we must maintain the version numbers year by year.

The same is for iOS but since that ecosystem is not part of Google, it uses different rules, schedules and sunsets.

@1n3JgKl9pQ6cUMrW thank you very much for the detailed explanation! highly appreciated

@jasonandress
Copy link

jasonandress commented Mar 30, 2023 via email

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 30, 2023

Thanks. I've gotten this far. What are the end points? I've installed plugins from GitHub and local before but this repo has multiple plugins in it.

Depends on the framework you are using for the app.

Ionic? Plain Cordova? Etc...

Maybe it's better to open a new topic for this, so others can also find answers for the same problem.

@jasonandress
Copy link

It's a plain cordova. I'm not asking how to install a plugin, I can do that. What's specific about this repo is there are many plugins.

I've tried this
cordova plugin add https://github.com/EYALIN/admob-plus/tree/master/packages/cordova —variable ...

I've tried the same but from my local, neither works.

Can you help?

@1n3JgKl9pQ6cUMrW
Copy link
Contributor

1n3JgKl9pQ6cUMrW commented Mar 30, 2023

Maybe it's better to open a new topic for this, so others can also find answers for the same problem.


This repo has just one plug-in, but it's wrapped in difference namespaces for different frameworks.

Ionic, Cordova (native), React, etc...

Your example is not a valid .git endpoint, it's the main repo.

Just download the package and unzip it to a local folder.

Than install it by pointing to the Cordova folder you need;

cordova plugin add /random/folder/admob-plus-master/packages/cordova/

The last folder must (as always) contain the plugin.xml so Cordova knows what's all about.

This is how it works since the very beginning, just check out this thread from ten years ago.


More info at the official page.

example


new

@ollm
Copy link
Member

ollm commented Mar 31, 2023

Before installing the repository, you have to build the js files first (Change the repo and package to the one you use), the npm install will probably give some errors, ignore them.

git clone https://github.com/admob-plus/admob-plus.git
cd admob-plus
npm install
cd packages/cordova
npm install tslib@2.5.0 --save-dev
npm install
npm run prepublishOnly

Now you can install the repo as follows.

cordova plugin add /you/folder/name/admob-plus/packages/cordova --save --variable ...

This only needs to be done again if you modify any of the js in the repo, if you change the java, xml... you just have to uninstall and install the plugin again.

@ollm
Copy link
Member

ollm commented Apr 8, 2023

@EYALIN you want me to push the changes from my fork to yours? My fork includes support for WebView API for Ads and a fix for the following bug on iOS #530 (cf773d9)

@DrMinh
Copy link

DrMinh commented Apr 8, 2023

@A32rj3gebebr This new plugin "community-admob-plus-cordova" (https://github.com/EYALIN/community-admob-plus) has the most up to date Ads SDK for IOS. also, we changed all the needed functions in order to support it. tested for 2 months now.

cool! Good to know the plugin still active.

@EYALIN
Copy link
Author

EYALIN commented Apr 8, 2023

@EYALIN you want me to push the changes from my fork to yours? My fork includes support for WebView API for Ads and a fix for the following bug on iOS #530 (cf773d9)

that will be great, thanks! :-)
also, I tried it in the past,but couldn't use it.
after you will push your fork, I will try to test it again.

אד
ארא

@ollm
Copy link
Member

ollm commented Apr 8, 2023

I sent my pull request EYALIN#1

When you can, also activate the issues tab in you fork

@Amaeta
Copy link

Amaeta commented Apr 10, 2023

Thank you @EYALIN Can you let us know which should be used from below (specifications)

admob-plus-cordova-webview-api-for-ads
community-admob-plus-cordova

community-admob-plus-cordova

I tried installing through Git, I get this error:
Installing "community-admob-plus-cordova" for android
Error during processing of action! Attempting to revert...
Failed to install 'community-admob-plus-cordova': CordovaError: Uh oh!

I

@ollm
Copy link
Member

ollm commented Apr 11, 2023

Have you removed the old plugin before adding the new one?

cordova plugin remove admob-plus-cordova

@Amaeta
Copy link

Amaeta commented Apr 11, 2023

Thanks @ollm. I created another app. Installation was successful. I built an Android app and installed on the phone. When I open the App, it breaks after the logo. Wondering what I did wrong. Use Plain Cordova. Like you suggested, admob-plugin-cordova is no longer part of the new build.

Is it a requirement to admob-plus-cordova-native?

@ollm
Copy link
Member

ollm commented Apr 11, 2023

What error appears in the logcat?

@Amaeta
Copy link

Amaeta commented Apr 11, 2023

What error appears in the logcat?

I use Notepad++ for file edit and run on chrome browser. On the browser. admob isn't fired so no issues. I build with Cordova build Android and install the apk file on my phone. This is where I notice the problem. I cant log.

@ollm
Copy link
Member

ollm commented Apr 11, 2023

Test the app in the Android Studio Emulator so you can see the errors in logcat.

@Amaeta
Copy link

Amaeta commented Apr 11, 2023

Test the app in the Android Studio Emulator so you can see the errors in logcat.

Thanks. Will do this and provide feedback

@EYALIN
Copy link
Author

EYALIN commented Apr 11, 2023

I sent my pull request EYALIN#1

When you can, also activate the issues tab in you fork

I tried to work with it, but had some errors using the webview.
but anyway it's merged, because it didn't cause any issue with the other ads.
will ask you some questions regarding it in a separated thread.

thanks a lot for your code donation! :-)

@EMI-INDO
Copy link

  • New Features | New Plugin | Bug fix

https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/releases/tag/v0.0.5

@Amaeta
Copy link

Amaeta commented Apr 11, 2023

Test the app in the Android Studio Emulator so you can see the errors in logcat.

loadUrl(javascript:cordova.plugins.backgroundMode._setActive(true);cordova.plugins.backgroundMode.on('activate', null);cordova.plugins.backgroundMode.fireEvent('activate',null);)
2023-04-11 19:17:59.034 13047-13047 CordovaActivity com.ik.. D Resumed the activity.
2023-04-11 19:17:59.035 13047-13047 CordovaWebViewImpl com.ik.. D >>> loadUrl(javascript:cordova.plugins.backgroundMode._setActive(false);cordova.plugins.backgroundMode.on('deactivate', null);cordova.plugins.backgroundMode.fireEvent('deactivate',null);)
2023-04-11 19:17:59.198 13047-13047 AndroidRuntime com.ik.. D Shutting down VM
2023-04-11 19:17:59.292 13047-13047 AndroidRuntime com.ik.. E FATAL EXCEPTION: main
Process: com.ik.., PID: 13047
java.lang.RuntimeException: Unable to create service de.appplant.cordova.plugin.background.ForegroundService: java.lang.IllegalArgumentException: com.ik..: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
at android.app.ActivityThread.handleCreateService(ActivityThread.java:4498)
at android.app.ActivityThread.-$$Nest$mhandleCreateService(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2161)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7872)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Caused by: java.lang.IllegalArgumentException: com.ik..: Targeting S+ (version 31 and above) requires that one of FLAG_IMMUTABLE or FLAG_MUTABLE be specified when creating a PendingIntent.
Strongly consider using FLAG_IMMUTABLE, only use FLAG_MUTABLE if some functionality depends on the PendingIntent being mutable, e.g. if it needs to be used with inline replies or bubbles.
at android.app.PendingIntent.checkFlags(PendingIntent.java:401)
at android.app.PendingIntent.getActivityAsUser(PendingIntent.java:484)
at android.app.PendingIntent.getActivity(PendingIntent.java:470)
at android.app.PendingIntent.getActivity(PendingIntent.java:434)
at de.appplant.cordova.plugin.background.ForegroundService.makeNotification(ForegroundService.java:223)
at de.appplant.cordova.plugin.background.ForegroundService.makeNotification(ForegroundService.java:163)
at de.appplant.cordova.plugin.background.ForegroundService.keepAwake(ForegroundService.java:132)
at de.appplant.cordova.plugin.background.ForegroundService.onCreate(ForegroundService.java:100)
at android.app.ActivityThread.handleCreateService(ActivityThread.java:4485)
... 9 more
2023-04-11 19:17:59.436 13047-13047 Process com.ik.. I Sending signal. PID: 13047 SIG: 9
---------------------------- PROCESS ENDED (13047) for package com.ik.. ----------------------------
2023-04-11 19:18:00.616 561-1861 AppOps pid-561 E Bad call made by uid 1000. Package "com.ik.." does not belong to uid -1.
2023-04-11 19:18:00.617 561-1861 AppOps pid-561 E noteOperation
java.lang.SecurityException: Specified package "com.ik.." under uid -1 but it is not
at com.android.server.appop.AppOpsService.verifyAndGetBypass(AppOpsService.java:4694)
at com.android.server.appop.AppOpsService.noteOperationUnchecked(AppOpsService.java:3453)
at com.android.server.appop.AppOpsService.noteOperationImpl(AppOpsService.java:3441)
at com.android.server.appop.AppOpsService.-$$Nest$mnoteOperationImpl(Unknown Source:0)
at com.android.server.appop.AppOpsService$CheckOpsDelegateDispatcher.lambda$noteOperation$4(AppOpsService.java:7640)
at com.android.server.appop.AppOpsService$CheckOpsDelegateDispatcher.$r8$lambda$oOwUoG55BBmJ6yiwhp3OAq3tQ30(Unknown Source:0)
at com.android.server.appop.AppOpsService$CheckOpsDelegateDispatcher$$ExternalSyntheticLambda1.apply(Unknown Source:32)
at com.android.server.policy.AppOpsPolicy.noteOperation(AppOpsPolicy.java:227)
at com.android.server.appop.AppOpsService$CheckOpsDelegateDispatcher.noteOperation(AppOpsService.java:7638)
at com.android.server.appop.AppOpsService.noteOperation(AppOpsService.java:3425)
at com.android.internal.app.IAppOpsService$Stub.onTransact(IAppOpsService.java:479)
at android.os.Binder.execTransactInternal(Binder.java:1280)
at android.os.Binder.execTransact(Binder.java:1244)

@EYALIN
Copy link
Author

EYALIN commented Apr 11, 2023

@Amaeta are the errors related to which plugin? what version?

@ollm
Copy link
Member

ollm commented Apr 12, 2023

@Amaeta the crash in your app is caused by the plugin cordova-plugin-background-mode.

You can try removing the plugin.

cordova plugin remove cordova-plugin-background-mode

Or apply one of the solutions discussed here katzer/cordova-plugin-background-mode#577

@Amaeta
Copy link

Amaeta commented Apr 12, 2023

@Amaeta the crash in your app is caused by the plugin cordova-plugin-background-mode.

You can try removing the plugin.

cordova plugin remove cordova-plugin-background-mode

Or apply one of the solutions discussed here katzer/cordova-plugin-background-mode#577

Thanks a bunch. Removed the background-mode plugin and it is working now. The only issue is that I can't get the native ad to show. Interstatia and banner works well. Could be my code?

function showNativeAd(){

    setTimeout(function() {
	ad.show({
      x: 0,
      y: 30,
      width: window.screen.width,
      height: 300,
    });
	}, 5000);
  
     setTimeout(function() {
          ad.hide();
        }, 5000);
  ad.showWith(document.getElementById('nativeads')); //id of the div I want to display my native ad. Using Cordova

};

@EMI-INDO
Copy link

EMI-INDO commented Apr 12, 2023

@Amaeta

Ads must be loaded before displaying

ad.load()
      .then(() =>
        ad.show({.....}) 

// ad.hide() 

https://github.com/admob-plus/admob-plus/blob/master/examples/cordova/www/js/index.js

@Amaeta
Copy link

Amaeta commented Apr 13, 2023

@Amaeta

Ads must be loaded before displaying

ad.load()
      .then(() =>
        ad.show({.....}) 

// ad.hide() 

https://github.com/admob-plus/admob-plus/blob/master/examples/cordova/www/js/index.js

Yes, I have ad.load(); first. Do I need to install the native admob plugin differently or does community-admob-plus plugin enough?

@ollm
Copy link
Member

ollm commented Apr 13, 2023

@Amaeta
Ads must be loaded before displaying

ad.load()
      .then(() =>
        ad.show({.....}) 

// ad.hide() 

https://github.com/admob-plus/admob-plus/blob/master/examples/cordova/www/js/index.js

Yes, I have ad.load(); first. Do I need to install the native admob plugin differently or does community-admob-plus plugin enough?

To use native ads it is necessary to install the admob-plus-cordova-native plugin or a custom fork of it.

You can get more information in the native ad documentation: https://admob-plus.github.io/docs/cordova/ads/native

@EMI-INDO
Copy link

emi-indo-cordova-plugin-admob ( New Platform IOS )

https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob/discussions/3

@EMI-INDO
Copy link

New Features AppOpenAd ( support Any mediation )

https://github.com/EMI-INDO/emi-indo-cordova-plugin-admob

@degroundshaker
Copy link

@1n3JgKl9pQ6cUMrW @mjapps-games @EMI-INDO @DrMinh @WynOwen72 @ollm @jasonandress @kisimediaDE @mujaffars I duplicated the plugin here:https://www.npmjs.com/package/community-admob-plus-cordova

Now you can install it with the npm for now, it's for Cordova only, if someone wants for different one, please update here.

will test it in the next few days, but it looks like it works.

I have installed it from npm, but i do not understand how to use it in my ionic app.

@EYALIN
Copy link
Author

EYALIN commented May 26, 2023

@degroundshaker can you be more specific? and you can open a new issue in the community-admob-plus-cordova plugin repo

@EMI-INDO
Copy link

@EYALIN
Copy link
Author

EYALIN commented May 27, 2023

I see that @ratson is back and merged some code. @ratson are you back? we are all waiting for you and highly appreciate your work

@EYALIN
Copy link
Author

EYALIN commented May 27, 2023

@ratson please update us if you are back.
personally, I want to give your sponsorship, and I'm sure much more people here

@ratson
Copy link
Member

ratson commented May 29, 2023

@EYALIN See my plan in #539 (comment)

For those need to the latest SDKs, please try the latest 2.0.0-alpha.1 version, it should be API compatible, except require Kotlin support.

@EMI-INDO Good work! For those looking for an alternative, feel free to try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests