Fixed #24424: sqlite syntax error on migrating abstract model

adnam · Feb 27, 2015 · 69575fd · 69575fd
1 parent 7182072
commit 69575fd
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/django/db/backends/sqlite3/schema.py b/django/db/backends/sqlite3/schema.py
@@ -137,10 +137,14 @@ def _remake_table(self, model, create_fields=[], delete_fields=[], alter_fields=
         self.create_model(temp_model)
         # Copy data from the old table
         field_maps = list(mapping.items())
+        insert_fields, select_fields = "", "*"
+        if field_maps != []:
+            insert_fields = "(" + ', '.join(self.quote_name(x) for x, y in field_maps) + ")"
+            select_fields = ', '.join(y for x, y in field_maps)
         self.execute("INSERT INTO %s (%s) SELECT %s FROM %s" % (
             self.quote_name(temp_model._meta.db_table),
-            ', '.join(self.quote_name(x) for x, y in field_maps),
-            ', '.join(y for x, y in field_maps),
+            insert_fields,
+            select_fields,
             self.quote_name(model._meta.db_table),
         ))
         # Delete the old table