Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Scalr webhook signature verification #200

Open
moorereason opened this issue Nov 20, 2017 · 12 comments
Open

Add support for Scalr webhook signature verification #200

moorereason opened this issue Nov 20, 2017 · 12 comments

Comments

@moorereason
Copy link
Collaborator

Requested by @hassanbabaie in #197 (comment).

Ref: https://github.com/scalr-tutorials/webhook

@hassanbabaie
Copy link
Contributor

Thanks for creating this ticket, I've reached out to Aloys (who did the original fork for us) to see if he can do a PR against the Development branch

@hassanbabaie
Copy link
Contributor

@moorereason & @adnanh Just to confirm, I've finished the tests with the code I copied over from @AloysAugustin fork and will start my pull request today. I might do it wrong, so don't hesitate to let me know. I plan to commit the code changes and then if all good I will propose some help document updates

@hassanbabaie
Copy link
Contributor

PR kicked off:
Add support for Scalr webhook signature verification (new Match Rule) #200 #209

hassanbabaie added a commit to hassanbabaie/webhook that referenced this issue Dec 19, 2017
Add a new match rule type that checks for a Scalr webhook signature. Tracking ticket adnanh#200

The signature algorithm is described here:
https://scalr-wiki.atlassian.net/wiki/spaces/docs/pages/6193247/Webhook+Security+and+Authentication

An example match rule ifor a Scalr webhook will look like:

"match": {
"type": "scalr-signature",
"secret": ""
}
@hassanbabaie
Copy link
Contributor

Hi @adnanh do you think my pull request (210) might make it into the next release? Also I would be interested in your thoughts on @dcj log file one

Thanks

Hass

@adnanh
Copy link
Owner

adnanh commented Jan 4, 2018

Hey @hassanbabaie, I'll review it as soon as I get some free time :-)

@hassanbabaie
Copy link
Contributor

That's great, thanks!

adnanh added a commit that referenced this issue Jan 16, 2018
Add support for Scalr webhook signature verification (new Match Rule) #200 - Updated
@hassanbabaie
Copy link
Contributor

Hi @adnanh I was looking at the Wiki to determine which ones to update and my thoughts are that I would add a section in Hook Examples with example and extra information and also a section in Hook rules

Let me know if this makes sense and I should have the PR done today

@moorereason
Copy link
Collaborator Author

@adnanh,

What are we doing with the wiki going forward? We moved the documentation into the docs folder. Can the wiki be deleted?

@hassanbabaie,

  1. Yes, add a section in Hook Examples.
  2. Also document the new scalr-signature Match type in Hook Rules.

@hassanbabaie
Copy link
Contributor

thanks!

@hassanbabaie
Copy link
Contributor

PR 218 submitted for document updates

@adnanh
Copy link
Owner

adnanh commented Jan 19, 2018

@moorereason I would replace the contents of the wiki pages with a link to the appropriate docs page, so if anyone bookmarked the wiki link will know where to go... What do you think?

@hassanbabaie
Copy link
Contributor

Hi @moorereason @adnanh did you get a chance to look at the help document PR I did? Also do we have an idea when 2.6.9 might be released (with maybe my Scalr bit...)?

Thank you for your help

regards

Nagging Hass!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants