-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Scalr webhook signature verification #200
Comments
Thanks for creating this ticket, I've reached out to Aloys (who did the original fork for us) to see if he can do a PR against the Development branch |
@moorereason & @adnanh Just to confirm, I've finished the tests with the code I copied over from @AloysAugustin fork and will start my pull request today. I might do it wrong, so don't hesitate to let me know. I plan to commit the code changes and then if all good I will propose some help document updates |
Add a new match rule type that checks for a Scalr webhook signature. Tracking ticket adnanh#200 The signature algorithm is described here: https://scalr-wiki.atlassian.net/wiki/spaces/docs/pages/6193247/Webhook+Security+and+Authentication An example match rule ifor a Scalr webhook will look like: "match": { "type": "scalr-signature", "secret": "" }
Hey @hassanbabaie, I'll review it as soon as I get some free time :-) |
That's great, thanks! |
Add support for Scalr webhook signature verification (new Match Rule) #200 - Updated
Hi @adnanh I was looking at the Wiki to determine which ones to update and my thoughts are that I would add a section in Hook Examples with example and extra information and also a section in Hook rules Let me know if this makes sense and I should have the PR done today |
What are we doing with the wiki going forward? We moved the documentation into the
|
thanks! |
PR 218 submitted for document updates |
@moorereason I would replace the contents of the wiki pages with a link to the appropriate docs page, so if anyone bookmarked the wiki link will know where to go... What do you think? |
Hi @moorereason @adnanh did you get a chance to look at the help document PR I did? Also do we have an idea when 2.6.9 might be released (with maybe my Scalr bit...)? Thank you for your help regards Nagging Hass! |
Requested by @hassanbabaie in #197 (comment).
Ref: https://github.com/scalr-tutorials/webhook
The text was updated successfully, but these errors were encountered: