Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to pass a mutative token for validation #416

Open
xblockchain opened this issue May 2, 2020 · 4 comments
Open

How to pass a mutative token for validation #416

xblockchain opened this issue May 2, 2020 · 4 comments

Comments

@xblockchain
Copy link

For example,the webhook implemented with a programmable app,and user has a token to pass for identifing his passport,the token will be different each request,not just pass a github/bitbucket json config,you can't write a mutative token as a immutable parameter with validation.

Any idea for this?

@moorereason
Copy link
Collaborator

You'll likely need to rely on an outside program to validate the token. Today, I'd say you would need to pass all of that off to the execute-command.

@adnanh is working on a "pre-hook" feature that could be used to do the token validation (with an outside program) and inject the JSON validation results into the rules conditions.

But out of curiosity, how is your token calculated? What would you need in order to validate the token?

@xblockchain
Copy link
Author

@moorereason A single App for trigger auto deploy the repository,not from github/bitbucket,that need identity the user's passport,he should be has a permission to execute the trigger action,so a token should be designed for this.

By the way,if a outside program designed,it seems a little complicated,if the developer will program with the new feature via adnanh,why not do the whole plan himself,adnanh will be not necessary

@moorereason
Copy link
Collaborator

Looking at this request again today, I'm not sure I understand exactly what you're wanting.

Can you mock up an example of how you would like this to work?

@adnanh
Copy link
Owner

adnanh commented Feb 28, 2021

@moorereason an example could be a TOTP implementation, something #356 could help with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants