Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log command output as it comes #344

Closed
wants to merge 0 commits into from
Closed

Conversation

bdubertret
Copy link

This PR allows the webhook server to log the script output as it comes, instead of waiting for the script to finish. This is useful for our use case, where the invoked script can take a long time, for example 15 minutes to complete.

@moorereason
Copy link
Collaborator

Thanks for taking the time to help make webhook better. A few things:

  1. I'd recommend creating an issue to discuss your enhancement request before submitting a PR.
  2. PRs should be made against the development branch, not master.
  3. Submit a separate PR to fix the UUID issue. That should be easier to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants