Feature/cipher suites #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default to TLS 1.2 and secure cipher suites. Built for Go 1.13. Code in cipher_suites.go taken from Go tip commit 0ee22d9, which is scheduled for the upcoming Go 1.14 release. Once Go 1.14 is released, we can remove this file and use the stdlib. Fixes adnanh#244
adnanh
reviewed
Dec 3, 2019
adnanh
approved these changes
Dec 3, 2019
Go 1.11 does not support TLS 1.3. To simplify cipher suite selection, we now require at least Go 1.12.
|
Regarding my comment about removing the |
|
Should we add the fact that we need at least 1.12 Go version in order to run this project to the README.md? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default to TLS 1.2 and secure cipher suites.
Built for Go 1.13. Code in cipher_suites.go taken from Go tip commit
0ee22d9, which is scheduled for the upcoming Go 1.14 release. Once Go
1.14 is released, we can remove this file and use the stdlib.
Fixes #244