Markup would be more accessible if ARIA attributes are changed

[accdc]

It works, though I'd recommend some changes.
 
Currently the triggering elements are marked up as links, but I'd recommend
role=button, since this would make it easier to quickly jump between each
triggering element using a screen reader, even though the styling would be the
same.
 
Also it uses aria-haspopup, which technically doesn't make much sense, because
it opens an accordion type interface for screen reader users, and not a menu as
implied regardless what the visual styling is.
 
The use of aria-expanded is good to indicate the state.
 
The use of role=group however would be better served using role=region instead,
because then you could use the screen reader region navigation commands to
quickly jump to the open accordion panel by pressing 'r' or 'shift+r', which
you cannot do using role=group.
 
Also, it would be good to set an explicit label for the role=region using
aria-labelledby that points back to the triggering element, so it is clear
which triggering element the region belongs to when jumping to it.
 
Also, regions can be nested, so you can tell what the structure is at the same
time when expanding sub sections if present.
 
Here is an accordion that uses this method for testing to see how it sounds:
http://whatsock.com/tsg/Coding%20Arena/ARIA%20and%20Non-ARIA%20Accordions/ARIA%20Accordion%20(Internal%20Content)/demo.htm 
Though aria-pressed isn't necessary in this case even though the demo uses this
method.

[mattmay]

Thanks. We're not actively working on this at the moment, but we'd gladly accept a pull request.

[accdc]

I’ve already fixed all of these things in a clone, but I’ll need to figure out how to do a pull request.

Do I need to set up a fork for this or can I just do this from the clone?

From: mattmay [mailto:notifications@github.com]
Sent: Friday, October 03, 2014 2:56 PM
To: adobe-accessibility/Accessible-Mega-Menu
Cc: Bryan Garaventa
Subject: Re: [Accessible-Mega-Menu] Markup would be more accessible if ARIA attributes are changed (#22)

Thanks. We're not actively working on this at the moment, but we'd gladly accept a pull request.

—
Reply to this email directly or view it on GitHub #22 (comment) .Image removed by sender.

[accdc]

Never mind, got and submitted the pull request.

From: mattmay [mailto:notifications@github.com]
Sent: Friday, October 03, 2014 2:56 PM
To: adobe-accessibility/Accessible-Mega-Menu
Cc: Bryan Garaventa
Subject: Re: [Accessible-Mega-Menu] Markup would be more accessible if ARIA attributes are changed (#22)

Thanks. We're not actively working on this at the moment, but we'd gladly accept a pull request.

—
Reply to this email directly or view it on GitHub #22 (comment) .Image removed by sender.