fix issue with lazy post-sync

adobe-apiplatform · Mar 25, 2020 · 7f743d9 · 7f743d9
1 parent e619033
commit 7f743d9
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/user_sync/post_sync/connectors/sign_sync/__init__.py b/user_sync/post_sync/connectors/sign_sync/__init__.py
@@ -44,7 +44,7 @@ def run(self, post_sync_data):
             return
         for org_name, sign_client in self.clients.items():
             # create any new Sign groups
-            for new_group in set(self.user_groups[org_name]) - set(sign_client.groups):
+            for new_group in set(self.user_groups[org_name]) - set(sign_client.sign_groups()):
                 self.logger.info("Creating new Sign group: {}".format(new_group))
                 sign_client.create_group(new_group)
             umapi_users = post_sync_data.umapi_data.get(org_name)

diff --git a/user_sync/post_sync/connectors/sign_sync/client.py b/user_sync/post_sync/connectors/sign_sync/client.py
@@ -25,6 +25,11 @@ def _init(self):
         self.api_url = self.base_uri()
         self.groups = self.get_groups()
 
+    def sign_groups(self):
+        if self.api_url is None or self.groups is None:
+            self._init()
+        return self.groups
+
     def logger_name(self):
         return 'sign_client.{}'.format(self.console_org if self.console_org else 'main')